From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27522 invoked by alias); 3 Dec 2015 14:37:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27419 invoked by uid 89); 3 Dec 2015 14:37:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 03 Dec 2015 14:37:19 +0000 Received: by pacej9 with SMTP id ej9so70148226pac.2 for ; Thu, 03 Dec 2015 06:37:17 -0800 (PST) X-Received: by 10.66.156.106 with SMTP id wd10mr13646965pab.150.1449153437738; Thu, 03 Dec 2015 06:37:17 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id dg1sm9100910pad.18.2015.12.03.06.37.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 03 Dec 2015 06:37:16 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [PATCH v4 3/6] Refactor arm_software_single_step to use regcache. References: <1449062264-18565-1-git-send-email-antoine.tremblay@ericsson.com> <1449062264-18565-4-git-send-email-antoine.tremblay@ericsson.com> <86egf3u8py.fsf@gmail.com> <56603F64.6050906@ericsson.com> Date: Thu, 03 Dec 2015 14:37:00 -0000 In-Reply-To: <56603F64.6050906@ericsson.com> (Antoine Tremblay's message of "Thu, 3 Dec 2015 08:11:00 -0500") Message-ID: <861tb3tx7s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00048.txt.bz2 Antoine Tremblay writes: > Unfortunately we do for the syscall_next_pc target dependent call. > > The reason I did not change syscall_next_pc for regcache is that this > would require the implementation of a syscall_next_pc that is not > using the frame unwinders and directly inspects the stack for multiple > targets. > > This would need to be done for arm, mips, nios2, and tix6x. > > software_single_step would also have to be adapted for mips, nios2 and > tix6x for this new api. We don't need to touch targets other than arm. syscall_next_pc is a function pointer in struct gdbarch_tdep in arm-tdep.h. /* Target-dependent structure in gdbarch. */ struct gdbarch_tdep { ... /* Return the expected next PC if FRAME is stopped at a syscall instruction. */ CORE_ADDR (*syscall_next_pc) (struct frame_info *frame);=20=20 ... }; we can change frame to regcache. The indentation looks odd in my mailer, if it is right to you, that is fine. Maybe, my mailer doesn't show the code format correctly. --=20 Yao (=E9=BD=90=E5=B0=A7)