From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25345 invoked by alias); 14 Jan 2016 13:43:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25330 invoked by uid 89); 14 Jan 2016 13:43:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f169.google.com Received: from mail-pf0-f169.google.com (HELO mail-pf0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 14 Jan 2016 13:43:17 +0000 Received: by mail-pf0-f169.google.com with SMTP id q63so103087452pfb.1 for ; Thu, 14 Jan 2016 05:43:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=zvmVIU+d9voJBb2XlN6gjopQaIZzA/xMZFsA1ZlEw/Y=; b=Hv/C3F+dW84aym6H+TjNJ/j/JU2G2GBuLia2A/VdzthaWa0JI3m6DQUyO1pV9DkbWJ RxwqKFlO1ByBLjqC+JWzmgU4uW50IFmj3W4ywvQP8lMeBC60ea9cK6vKQdbX2jtkenjv ADkx0u75rtiqO+o2xN/Lk+56ZA2LT5cIzYFSPqJ1UwNh1E5tjlcvYwmoQjkIu67PInWF w8rSi7uke4k12aLKhkzGDCGjnz4KmMDRu5fh5VlbpHVEQRBXbtdrept4UlR9jYntbQ4I GQ66dorNWWsQwj0HZWWOD5Dq4uoSjZp3uYjerIp4dN51E2E/XQYDrhnJE1puIz1HDoXk f5CQ== X-Gm-Message-State: ALoCoQkuxmYpnyLNeCm30lYsGNPy/0b+WbHHccENRfFwB/YNyenKN5gpnISiUaJjyaiOOklCq9wJzm6LaJt8fMiqTzFvzT/09w== X-Received: by 10.98.65.90 with SMTP id o87mr5827281pfa.115.1452778995455; Thu, 14 Jan 2016 05:43:15 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id m87sm9578083pfi.47.2016.01.14.05.43.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 14 Jan 2016 05:43:14 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Yao Qi , Subject: Re: [PATCH] [ARM] Remove field syscall_next_pc in struct gdbarch_tdep References: <1452704004-6821-1-git-send-email-yao.qi@linaro.org> <5696A385.5090702@ericsson.com> <8660ywv60q.fsf@gmail.com> <56979D96.80602@ericsson.com> Date: Thu, 14 Jan 2016 13:43:00 -0000 In-Reply-To: <56979D96.80602@ericsson.com> (Antoine Tremblay's message of "Thu, 14 Jan 2016 08:07:34 -0500") Message-ID: <861t9kuviv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00296.txt.bz2 Antoine Tremblay writes: > Maybe it's only in the email ? but it seems like it's > > static CORE_ADDR > arm_linux_get_next_pcs_syscall_next_pc (struct arm_get_next_pcs *self, > > When it should be : > > static CORE_ADDR > arm_linux_get_next_pcs_syscall_next_pc (struct arm_get_next_pcs *self, No, it is intended. We don't write declaration at column zero. See https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards --=20 Yao (=E9=BD=90=E5=B0=A7)