From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51312 invoked by alias); 25 Feb 2016 10:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51274 invoked by uid 89); 25 Feb 2016 10:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 25 Feb 2016 10:35:34 +0000 Received: by mail-pf0-f193.google.com with SMTP id w128so2598166pfb.2 for ; Thu, 25 Feb 2016 02:35:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=TetwMm+ZEHXXVJppPTHVlbUzPVMhBXM7AsBSJos7mVc=; b=KFlyGJpq4156d/vqtIMCYV8IhXIZROrvkbyT6TwioRTst/IMF6pqHJXJDIuOZ1R+na xThXR63akyyf2hLQDhKFxOROWGcjlplaI9WYkYj6mfwRkYdoxM17D+2k01Q/QOYYMRVD 7I1FiOG3Jyz4UMiauGopsLMb7+RjnfaJWc6rmCfiErfHM/uuUvdNELy/+ZMf0UV2JbmM PzQ3MXxw07bIHBv+MUCtd2BfZQusekXlD5fn01VuQLJBxXNcfL/AWk5uQOWDYtKaAKOU PmIeozy8nFgZQ18pRRB5lBkeddYKxSYR6olBgdHqqtQJkANxcVacbw7C+LROFQ3f9wJX 2ExQ== X-Gm-Message-State: AG10YOQaHmaHtcAt15vLrGSjoeGLsr93zZXIgepNSza4C1vdQiZT47eNqvDqOlB6yqTW4w== X-Received: by 10.98.17.129 with SMTP id 1mr61965089pfr.30.1456396532053; Thu, 25 Feb 2016 02:35:32 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ml5sm11276638pab.2.2016.02.25.02.35.29 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 25 Feb 2016 02:35:31 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: , Subject: Re: [PATCH v5] Enable tracing of pseudo-registers on ARM References: <56C7796B.3030504@redhat.com> <1456256486-26423-1-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 25 Feb 2016 10:35:00 -0000 In-Reply-To: <1456256486-26423-1-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Tue, 23 Feb 2016 14:41:26 -0500") Message-ID: <861t81cc2c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00776.txt.bz2 Antoine Tremblay writes: > +/* Implementation of the ax_pseudo_register_collect gdbarch function. */ > + > +static int > +arm_ax_pseudo_register_collect (struct gdbarch *gdbarch, > + struct agent_expr *ax, int reg) > +{ > + int rawnum =3D arm_pseudo_register_to_register (gdbarch, reg); > + > + /* Error. */ > + if (rawnum < 0) > + return 1; > + > + /* Get the remote/tdesc register number. */ > + rawnum =3D gdbarch_remote_register_number (gdbarch, rawnum); > + I am expecting your patch v6 which moves gdbarch_remote_register_number to the else branch of ax_reg/ax_reg_mask, if I correctly follow the discuss= ion. > + ax_reg_mask (ax, rawnum); > + > + return 0; > +} --=20 Yao (=E9=BD=90=E5=B0=A7)