From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6120 invoked by alias); 28 Apr 2016 09:23:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5852 invoked by uid 89); 28 Apr 2016 09:23:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=ptid, ptid_t, HX-Received:10.98.66.80 X-HELO: mail-pf0-f169.google.com Received: from mail-pf0-f169.google.com (HELO mail-pf0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 28 Apr 2016 09:22:52 +0000 Received: by mail-pf0-f169.google.com with SMTP id y69so31399745pfb.1 for ; Thu, 28 Apr 2016 02:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UXmRI4oWicjYKpAhJMSFJc3EbOVDPhJ0dIeg5orZ210=; b=cREVKtO6TH10e0QEnh7DzMkcE33V0hSs0Rhc8TqdrjQptLcsKR8lhZMyEKptXhD1iL 9UDkV2Cg+TTb8bDaHPI5MYrAOyGr3Easa9r3iBa/bcyUXPCxQKLclZQv2RyDkNlVloC3 WixdQ7pDX+YZQVOma1UhuoDJlHDsL7GPMSdgORxqzU5RrgBWCuCPUcGQfMece48dKvgO LH/R9lPR5XH1MQ88sKxzIcD98m5VAuReqTJ3cDHcITrLKNZxGV7E9BHxcgDwuQpZbJgW 3B7wZHjGrTXayffmEiPwkU8ePg7ljhcMK5oks2iiYopo3E7NIJCyYkmyz5j8pytbE47F dTrw== X-Gm-Message-State: AOPr4FUcWx+t/Y2lWXmeLIx2ALF7V+6foimJZaq6faL1BOvyklzAursGpm7GTR9IR3LvZw== X-Received: by 10.98.66.80 with SMTP id p77mr18739071pfa.75.1461835370946; Thu, 28 Apr 2016 02:22:50 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 199sm13194001pfc.15.2016.04.28.02.22.48 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 28 Apr 2016 02:22:49 -0700 (PDT) From: Yao Qi To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Remove need_step_over from struct lwp_info References: <1461657497-12076-1-git-send-email-yao.qi@linaro.org> Date: Thu, 28 Apr 2016 09:23:00 -0000 In-Reply-To: <1461657497-12076-1-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Tue, 26 Apr 2016 08:58:17 +0100") Message-ID: <861t5qf5p6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00630.txt.bz2 Yao Qi writes: > @@ -3276,9 +3276,6 @@ linux_wait_1 (ptid_t ptid, > PC), we should step over it. */ > if (debug_threads) > debug_printf ("Hit a gdbserver breakpoint.\n"); > - > - if (breakpoint_here (event_child->stop_pc)) > - event_child->need_step_over =3D 1; Looks the comments above should be removed as well, /* If we stepped or ran into an internal breakpoint, we've already handled it. So next time we resume (from this PC), we should step over it. */ --=20 Yao (=E9=BD=90=E5=B0=A7)