Re: [PATCH 06/12] Pass breakpoint type in set_breakpoint_at

Pedro Alves
2016-06-13T15:07:58Z

On 06/02/2016 10:30 AM, Yao Qi wrote:
> V2: rename set_breakpoint_at_1 to set_breakpoint_type_at
>
> Nowadays, set_breakpoint_at creates breakpoint of type
> other_breakpoint, but we also use set_breakpoint_at
> in set_reinsert_breakpoint to create breakpoint, so that
> we have to overwrite the breakpoint type like this,
>
> bp = set_breakpoint_at (stop_at, NULL);
> bp->type = reinsert_breakpoint;
>
> which looks not very good. This patch changes set_breakpoint_at
> to receive breakpoint type. Since set_breakpoint_at is
> used in many places, I rename it to set_breakpoint_type_at, and wrap
> it with set_breakpoint_at, and pass other_breakpoint. In this way,
> we can call set_breakpoint_type_at with reinsert_breakpoint in
> set_reinsert_breakpoint too, and code looks cleaner.
>
> gdb/gdbserver:
>
> 2016-05-31 Yao Qi <yao.qi@linaro.org>
>
> * mem-break.c (set_breakpoint_at): Rename it to ...
> (set_breakpoint_type_at): ... it.
> (set_breakpoint_at): Call set_breakpoint_type_at.
> (set_reinsert_breakpoint): Call set_breakpoint_type_at.
> * mem-break.h (set_breakpoint_at): Update comments.

OK.

Thanks,
Pedro Alves