From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t3YrBI9ZDmaL2iIAWB0awg (envelope-from ) for ; Thu, 04 Apr 2024 03:41:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=mj3Spkae; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F24191E0C0; Thu, 4 Apr 2024 03:41:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 95EDE1E08C for ; Thu, 4 Apr 2024 03:41:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB8BF3858410 for ; Thu, 4 Apr 2024 07:40:59 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A7E913858C62 for ; Thu, 4 Apr 2024 07:40:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7E913858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A7E913858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712216439; cv=none; b=j15kHlWrDAW8uklQdGnqyLKrrEFpEQkUm+wkgCVYZhoyYwtDbgLBTZexBRzi+QHIR/pDwGtIxBlYRvK8uB+4WacIhAI9zLZCjOATpFaEhIkT/AoAKZARjd8LMh5RnEnwJXb2RXyiuO7gmpi04chfB9PtznaH29hHRcJ0eZldVTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712216439; c=relaxed/simple; bh=FeJ959p6ZnGge7ZdxnUxXrmCr1WkxrgL5ciujPBofHU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=sdqoYqYD41pZfORdaCA5/vkP+TWW9nP8RNLKuRiqN6/zgoAH6h7BFvanRz5swS05hmWObdmbcC4Rqe6OF28sD1nxSt2cs6/iGzM9X16c+HD7AXZ2VWHqw8eMtFJFx/vV/M46G3KcJ3GnWKI9scfun6DZ3/GYbB0Y9Haoa3/ucD0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsHi7-0003Tx-ER; Thu, 04 Apr 2024 03:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pMFnMRO408x8HCgrv+kfATeZgGQAL5etgOZ+/qaafYw=; b=mj3Spkae21eC fKsRpjvDUwUkUZ1Y/HJCY1fGWR2gv2NrBvASiv/kjTleA8Wi0S9tSQa7HHoyi02Xnmo83ya9qAz+X PXcMJ+bcFBxxY0LztpCarELvtx/1ABGGwa3Vk54DRssc4DuZB3O2oykato2MvlJ1MGJOFXUR0byDh qWgamINM9QsdhbI473VMKCxF1dq8Bjzb4RIZV5UuEcbyxellkDKANyI7+nbNFlbya6pzwVJTqPWeS EI1za9YXXo+jHJCK8SQzKoSPp9qKAK2MIxab0guwu4HljPUrx28zZMw1CORaIsZIvG43ErBUx7SQ0 RRiicRxFBL8EPenIbIA6TQ==; Date: Thu, 04 Apr 2024 10:40:31 +0300 Message-Id: <861q7l8tjk.fsf@gnu.org> From: Eli Zaretskii To: Gustavo Romero Cc: gdb-patches@sourceware.org, luis.machado@arm.com, thiago.bauermann@linaro.org In-Reply-To: <20240404064819.2848899-8-gustavo.romero@linaro.org> (message from Gustavo Romero on Thu, 4 Apr 2024 06:48:19 +0000) Subject: Re: [PATCH v3 7/7] gdb: Document qMemTagCheckAddr packet References: <20240404064819.2848899-1-gustavo.romero@linaro.org> <20240404064819.2848899-8-gustavo.romero@linaro.org> X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Gustavo Romero > Cc: luis.machado@arm.com, thiago.bauermann@linaro.org, > gustavo.romero@linaro.org > Date: Thu, 4 Apr 2024 06:48:19 +0000 > > This commit documents the 'qMemTagCheckAddr' packet and the associated > feature 'memory-tagging-check-addr' that informs if this packet is > supported by the target. > > Signed-off-by: Gustavo Romero > --- > gdb/NEWS | 9 ++++++++ > gdb/doc/gdb.texinfo | 50 ++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 56 insertions(+), 3 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index feb3a37393a..1158715f41c 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -192,6 +192,15 @@ QThreadOptions in qSupported > QThreadOptions packet, and the qSupported response can contain the > set of thread options the remote stub supports. > > +qMemTagCheckAddr > + This new packet allows GDB to query the stub about a given address to check if > + it is tagged or not. Many memory tagging-related GDB commands need to perform > + this check before they read/write the allocation tag related to an address. > + Currently, however, this is done through a 'vFile' request to read the file > + /proc//smaps and check if the address is in a region reported as memory > + tagged. Since not all targets have a notion of what the smaps file is about, > + this new packet provides a more generic way to perform such a check. Please reformat this text so that each line is shorter than 78 columns. Also, please leave two spaces between sentences, per our conventions. > +@item qMemTagCheckAddr:@var{address} > +@anchor {qMemTagCheckAddr} > +@cindex check if a given address is in a memory tagged region. > +@cindex @samp{qMemTagCheckAddr} packet > +Check if address @var{address} is in a memory tagged region; if it is, it's said > +to be tagged. The target is responsible for checking it, as this is > +architecture-specific. Likewise here: please make the lines shorter. Also, the @cindex lines should come _before_ the @item line, not after it, so that the index entry records the location before the @item. > +Reply: > +@table @samp > +Replies are in a 2 hex digits format. This should be before @table, like this: Replies to this packet should all be in two hex digit format, as follows: @item @var{01} > +stub. Access to the @file{/proc/@var{pid}/smaps} file is done via @samp{vFile} ^^ Two spaces between sentences, please. Reviewed-By: Eli Zaretskii