From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C4+jGYH9i2Zdxx8AWB0awg (envelope-from ) for ; Mon, 08 Jul 2024 10:53:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=bbkA/dPA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 52CAB1E0C3; Mon, 8 Jul 2024 10:53:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 056491E097 for ; Mon, 8 Jul 2024 10:53:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9225B3864839 for ; Mon, 8 Jul 2024 14:53:50 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B1612386480F for ; Mon, 8 Jul 2024 14:53:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1612386480F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B1612386480F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720450413; cv=none; b=dlPE1EBQ+Sh+8VuOm3nDtZPV2I10h800CYrpE+D6l01oH+E/Qgv8rz338cGCR2LsOEy5pljGrz0e/hpdJSjh9gINRDIxXJKznFsjNlCXN/pOYNsu3TfSUbD26YfvOoYMDI6Exa8zsQKZjbVkQlUwF3hYuCa8rDO7VGf6aRx2vjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720450413; c=relaxed/simple; bh=lLFj94UtoFIB1biJqsMNV0DxB55GzC2cdoewRH/qmoY=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=bw3daSPfgBEEiiRoXntusc8jeC3O436D5alONuLIscItPlAMLqqONoGfRkiYqgH7jkErisalzqEBNT/pzBOyy3HX8vEr5jEFH1W173f6j4IJXTAxUrpgz9fRON/mG7X/krl37R/sw6K9HDEEIYFcxyu0DBbheDG/fVElquxaeKg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQpkA-0007TD-Oq; Mon, 08 Jul 2024 10:53:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EmdQdGJnBJkcRW1HFxoTQ81tIzuCYif8Tsd6cN8pqbo=; b=bbkA/dPAWoyV Kh2B5S91kvey/Nt+p6vnj0e9XafVdRDuf9Sg0wySVZoGpevwleQFLba9P99zEAix2zpKtmK4KP4RL 8H6rImNVtI8CCYpiMmfJjDVzDBRIPHghJQ0QTUrHX/nvsRgMzyzGuGCzuIaVtxIrHoADjhXBsZSCM KaUUswtbX/IwxMYsQEnWU/plBi9n/QgSKq3iDkXVCLcJTbWoz2oAbOAeFwHO05MchMYrbrkS+tptk udLngfJOygg838936AGK+h31daPSg0ja4J+MYNsGNdeyEPtKJvz+7kMM1URWwtaPYxKYuGIHDmCiU a3sRgrUaUJCRez6JO+4cAw==; Date: Mon, 08 Jul 2024 17:53:15 +0300 Message-Id: <861q440wbo.fsf@gnu.org> From: Eli Zaretskii To: "Schimpe, Christina" Cc: gdb-patches@sourceware.org, felix.willgerodt@intel.com, luis.machado@arm.com In-Reply-To: (christina.schimpe@intel.com) Subject: Re: [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints. References: <20240704101736.3074236-1-christina.schimpe@intel.com> <20240704101736.3074236-3-christina.schimpe@intel.com> <86tth58gk7.fsf@gnu.org> <86plrt8d5w.fsf@gnu.org> <86cyns6rpc.fsf@gnu.org> <867cdw1555.fsf@gnu.org> X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: "Schimpe, Christina" > CC: "gdb-patches@sourceware.org" , "Willgerodt, > Felix" , "luis.machado@arm.com" > > Date: Mon, 8 Jul 2024 14:25:50 +0000 > > I understand that the NEWS text seems rather short, especially compared > to my commit message. > One reason why I kept the NEWS generic (without LAM and its specifics) is > because theoretically the patch should work for AMD's tagged pointer support, too. > They call their tagged pointer support "upper address ignore" (UAI). > > However, I still could mention LAM in that way in the NEWS: > > - GDB now supports watchpoints for tagged data pointers on amd64, > e.g. as provided by Intel's linear address masking (LAM) feature. > > or > > - GDB now supports watchpoints for tagged data pointers on amd64. > For more information on tagged data pointers, see > https://en.wikipedia.org/wiki/Tagged_pointer. > > Although given that I did not test UAI and don't know about its current > state, I think it's better to use my first suggestion. I think we can do both: GDB now supports watchpoints for tagged data pointers (see https://en.wikipedia.org/wiki/Tagged_pointer) on amd64, such as the one used by the Linear Address Masking (LAM) feature provided by Intel. > If you don't like my current suggestion, I have no problem adding a > proper documentation on tagged pointers in the manual or adding > more info to the NEWS. An informative enough NEWS entry should be fine in this case, I think. Thanks.