From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82081 invoked by alias); 30 Nov 2016 11:51:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82063 invoked by uid 89); 30 Nov 2016 11:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 11:51:14 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2DDD67F6C8; Wed, 30 Nov 2016 11:51:13 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUBpBFA026301; Wed, 30 Nov 2016 06:51:12 -0500 Subject: Re: [PATCH] Makefiles: Disable suffix rules and implicit rules To: Simon Marchi , gdb-patches@sourceware.org References: <20161126040405.20929-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <860f3cbf-e062-0481-1f3b-a26ea1fd5f59@redhat.com> Date: Wed, 30 Nov 2016 11:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161126040405.20929-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00972.txt.bz2 On 11/26/2016 04:04 AM, Simon Marchi wrote: > > gdb/ChangeLog: > > * disable-implicit-rules.mk: New file. Please add a copyright header. > * Makefile.in: Include disable-implicit-rules.mk. > * data-directory/Makefile.in: Likewise. > * doc/Makefile.in: Likewise. doc/ has its own ChangeLog file. What about gnulib/Makefile.in ? Otherwise LGTM. (I suspect that we could move more common things to a shared fragment, like e.g., NOEXPORT and MAKEOVERRIDES, though the later maybe we don't need anymore. ) Thanks, Pedro Alves