On 05.02.2020 19:02, Christian Biesinger via gdb-patches wrote: > On Mon, Jan 27, 2020 at 7:38 AM Christian Biesinger > wrote: >> >> On Fri, Jan 24, 2020 at 5:37 PM Kamil Rytarowski wrote: >>> >>> On 24.01.2020 17:01, Christian Biesinger wrote: >>>> On Fri, Jan 24, 2020 at 4:49 PM Kamil Rytarowski wrote: >>>>> >>>>> On 24.01.2020 16:35, Christian Biesinger via gdb-patches wrote: >>>>>> On Fri, Jan 24, 2020 at 4:23 PM Kamil Rytarowski wrote: >>>>>>> >>>>>>> On 24.01.2020 15:53, Christian Biesinger via gdb-patches wrote: >>>>>>>> Hi Kamil, >>>>>>>> >>>>>>>> I have a related question. NetBSD applied this patch: >>>>>>>> https://www.mail-archive.com/tech@openbsd.org/msg44100.html >>>>>>>> >>>>>>> >>>>>>> Is this the right link? >>>>>> >>>>>> Yeah -- that patch changes a system header at the top and patches GDB >>>>>> at the bottom. >>>>>> >>>>> >>>>> This is not a change in NetBSD, so it is unrelated. >>>> >>>> My apologies, I completely misread that. I'll see if I can find where >>>> NetBSD changed their FP register data structure, or perhaps your >>>> downstream patch will still work (although that probably has to come >>>> from one of y'all for copyright reasons?) >>>> >>> >>> Please cherry-pick what you need and I will find the original author. >>> Many people in NetBSD have FSF papers done. >> >> Thanks. I think this patch would probably be the most important since >> it fixes a compile error: >> https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_arm-nbsd-nat.c >> >> However, I don't understand why arm_netbsd_core_fns / >> fetch_core_registers was added. As far as I can tell, because that >> struct uses bfd_target_unknown_flavour and default_core_sniffer, it >> will never be used. > > Hi Kamil, > > I also filed https://github.com/NetBSD/pkgsrc-wip/issues/17 on some > patches that can be dropped, and I upstreamed a couple of > trivial/obvious patches you had. > > Christian > Thank you for your contribution!