From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DKlkBvR05WfHkxwAWB0awg (envelope-from ) for ; Thu, 27 Mar 2025 11:55:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bJiG5eLn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 06A091E0C3; Thu, 27 Mar 2025 11:55:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 210031E0C0 for ; Thu, 27 Mar 2025 11:55:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AAB87382E295 for ; Thu, 27 Mar 2025 15:55:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AAB87382E295 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bJiG5eLn Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9E5B63858288 for ; Thu, 27 Mar 2025 15:54:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E5B63858288 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E5B63858288 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743090895; cv=none; b=DCr1lRNO8JVaYjxSrlNeXp5m5lL/REshm6sHC3E5+QZTLwRyKxerP+N9xPOoNhIJyqjb34ulmrzCjeW9oUdhKpsiJXH5ft7YgiXgP0gAiHpz5sxNZz6aJOki0qH6Ydi1BzHmReDAj6RGoECnUXs4cD8BisIBbBAf/yLhHc3W+zA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743090895; c=relaxed/simple; bh=hdAQP0bxpfnBoVKxuIlThpQXIYX8GkQ69QockhA2dLs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QUSTN3Gg1bMLAMAy05prfdgF1zP27pNC2jF8AJx6hmZJt4Qm6IZhsTmkYibVCPTsbJJa7OIEZV+Rg60vyAAoAmgYXWTpy2n+fNT6XIZOURxm+BQgYpyLwPNl9CcqFtY16OQg7yLfO68DMUAkLBOvjsSezM0hbJydD8FrchS24B4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E5B63858288 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743090895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZDeFAccgK8nd0JAFzwiWOQ4tDBI8sLQlmhS1uLiAy5g=; b=bJiG5eLnMbIRMtk9FmsHhsJMkqlRKOJoxVzkA3HgKpOlP/y8oSO4bGuMj/71Y2A0eiWsBA KanchfCrU6TQyEciOidF7uQkbf7ngeZcQpsVqc5vBchIKfNOq3H8hk69H7TDI0dTJTa7k1 BQA113B1uFpcKmM1IvyVPunG3qrjXB4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-6uMBsed4NbqMySs5sHnTmg-1; Thu, 27 Mar 2025 11:54:53 -0400 X-MC-Unique: 6uMBsed4NbqMySs5sHnTmg-1 X-Mimecast-MFC-AGG-ID: 6uMBsed4NbqMySs5sHnTmg_1743090892 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B90A61955D84 for ; Thu, 27 Mar 2025 15:54:52 +0000 (UTC) Received: from guittard.redhat.com (unknown [10.22.81.90]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 00F55180094A for ; Thu, 27 Mar 2025 15:54:51 +0000 (UTC) From: Keith Seitz To: gdb-patches@sourceware.org Subject: [PATCH] Fix gstack issues Date: Thu, 27 Mar 2025 08:54:50 -0700 Message-ID: <85d8b0e904d7893d55db6531edb64d4a16062a46.1743090890.git.keiths@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w8zoV5dVeKk7mmdy9GNfpsDDjc3bkOVZuUp5zR8Ckm8_1743090892 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With commit fb2ded33c1e519659743047ed7817166545b6d91, I added Fedora's gstack script to gdb. Some issues have arisen since then, and this patch addresses those issues: . As Sam James recently noted[1], PKGVERSION and VERSION need to be quoted. . A Fedora user reported the misuse of --readnever, which causes gstack to omit filename and line number information in the backtrace[Red Hat BZ 2354997]. [1] https://inbox.sourceware.org/gdb-patches/d19d6bc17e0a160ce27fc572079f11a587c0e168.1742424869.git.sam@gentoo.org/ Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2354997 --- gdb/gstack-1.in | 8 ++++---- gdb/testsuite/gdb.base/gstack.exp | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/gdb/gstack-1.in b/gdb/gstack-1.in index 5e413290c9a..25339d9877d 100755 --- a/gdb/gstack-1.in +++ b/gdb/gstack-1.in @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# Copyright (C) 2024 Free Software Foundation, Inc. +# Copyright (C) 2024-2025 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -22,8 +22,8 @@ GDB=${GDB:-$(command -v gdb)} GDBARGS=${GDBARGS:-} AWK=${AWK:-} -PKGVERSION=@PKGVERSION@ -VERSION=@VERSION@ +PKGVERSION="@PKGVERSION@" +VERSION="@VERSION@" # Find an appropriate awk interpreter if one was not specified # via the environment. @@ -132,7 +132,7 @@ EOF ) # Run GDB and remove some unwanted noise. -"$GDB" --quiet -nx --readnever $GDBARGS <