From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10505 invoked by alias); 27 Jun 2017 15:30:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2352 invoked by uid 89); 27 Jun 2017 15:30:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1184 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 15:30:31 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D08D4A544; Tue, 27 Jun 2017 15:30:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7D08D4A544 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7D08D4A544 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0403E17C05; Tue, 27 Jun 2017 15:30:28 +0000 (UTC) Subject: Re: [PATCH 07/40] objfile_per_bfd_storage non-POD To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-8-git-send-email-palves@redhat.com> <867ezxfxng.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <85cafdd6-ae90-2bc0-6a8c-180996fb6767@redhat.com> Date: Tue, 27 Jun 2017 15:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <867ezxfxng.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00731.txt.bz2 On 06/27/2017 01:00 PM, Yao Qi wrote: > Pedro Alves writes: > >> A following patch will want to add a std::vector to >> objfile_per_bfd_storage. That makes it non-trivially >> constructible/destructible. Since objfile_per_bfd_storage objects are >> allocated on an obstack, we need to call their ctors/dtors manually. >> This is what this patch does. And then since we can now rely on >> ctors/dtors being run, make objfile_per_bfd_storage::storage_obstack >> be an auto_obstack. > > It is good trick to class-fy some structures which are allocated on > obstack. > >> >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * objfiles.c (get_objfile_bfd_data): Call bfd_alloc instead of >> bfd_zalloc. Call objfile_per_bfd_storage's ctor. >> (free_objfile_per_bfd_storage): Call objfile_per_bfd_storage's >> dtor. >> * objfiles.h (objfile_per_bfd_storage): Add ctor. Make >> 'storage_obstack' field an auto_obstack. In-class initialize all >> non-bitfield fields. Make minsyms_read bool. >> * symfile.c (read_symbols): Adjust. > > Patch is good to me. > Thanks, pushed it in. Thanks, Pedro Alves