From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33345 invoked by alias); 20 Sep 2017 18:39:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33329 invoked by uid 89); 20 Sep 2017 18:39:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 18:39:04 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A45B806AC; Wed, 20 Sep 2017 18:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A45B806AC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85AAD600C2; Wed, 20 Sep 2017 18:39:02 +0000 (UTC) Subject: Re: [patch] Allow to link with ncursesw To: Matthias Klose , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <85b197cb-3a52-2e96-e7a3-a387afc3f158@redhat.com> Date: Wed, 20 Sep 2017 18:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00514.txt.bz2 On 09/13/2017 11:29 AM, Matthias Klose wrote: > Triggered by https://launchpad.net/bugs/1275210, to be able to cope with UTF-8 > characters in gdbtui. Ok for the trunk? > > Matthias > > * configure.ac: Search ncursesw before ncurses. > Check ncursesw/ncurses.h before ncurses/ncurses.h. > * gdb_curses.h: Include > * config.in, configure: Regenerate. > This sounds a bit scary if readline (or Python?) links with ncurses. Looking both upstream readline sources and our local copy in the tree, I don't see anything checking for ncursesw. Looking around for ncurses + ncursesw, I found: https://bugs.python.org/issue9408 https://bugs.python.org/issue7384 "Python3 now links _curses.so to ncurses library (bytes version) instead of ncursesw library (unicode version) if readline is linked to ncurses." .... "Thomas Dickey recommended not to load readline+ncurses and ncursesw at the same time." And: https://bugs.mageia.org/show_bug.cgi?id=2156 bugs.debian.org/cgi-bin/bugreport.cgi?bug=602720 I see you've been involved with all this before. Did you reach out to readline/bash, see if they're willing to try ncursesw before ncurses too? Don't we need at least a local patch to our local readline copy, to avoid breaking those that use it and have it link with ncurses? Thanks, Pedro Alves