From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 36AC4387086C for ; Thu, 7 May 2020 19:54:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36AC4387086C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2E1C11E581; Thu, 7 May 2020 15:54:30 -0400 (EDT) Subject: Re: [PATCH 2/4] gdbserver: Don't add extra NULL to program args To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-4-m.weghorn@posteo.de> From: Simon Marchi Message-ID: <859daf15-0142-5d78-4c35-594f104fba6b@simark.ca> Date: Thu, 7 May 2020 15:54:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429111638.1327262-4-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2020 19:54:32 -0000 On 2020-04-29 7:16 a.m., Michael Weghorn via Gdb-patches wrote: > The vector holding the program args is passed as a parameter > to target_create_inferior, which then passes it to > stringify_argv for all platforms, where any NULL entry in > the vector is ignored, so there seems to be no reason > to actually add one after all. > > (Since the intention is to replace uses of stringify_argv with > construct_inferior_arguments in a follow-up commit and that > function doesn't currently handle such NULL arguments, it > would otherwise have to be extended.) Thanks, this LGTM. And a big thank you for writing informative commit messages up front, those help a lot understand the need for your changes. Simon