From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125254 invoked by alias); 7 Mar 2019 16:25:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112385 invoked by uid 89); 7 Mar 2019 16:25:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:257 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Mar 2019 16:25:17 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3BAF51E477; Thu, 7 Mar 2019 11:25:15 -0500 (EST) Subject: Re: [PATCH v2 05/11] Remove code disabled since at least 1999 from lookup_struct_elt_type. To: John Baldwin , gdb-patches@sourceware.org References: From: Simon Marchi Message-ID: <856cb7bd-6acd-04a2-d202-0ff62abdf941@simark.ca> Date: Thu, 07 Mar 2019 16:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00152.txt.bz2 On 2019-02-08 7:40 p.m., John Baldwin wrote: > Update the comment above the function to reflect the code removal and > document the existing behavior. LGTM. Simon