From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qq5EN013ZGC5CgAAWB0awg (envelope-from ) for ; Wed, 31 Mar 2021 09:21:17 -0400 Received: by simark.ca (Postfix, from userid 112) id CD9C81EE14; Wed, 31 Mar 2021 09:21:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E2E611E590 for ; Wed, 31 Mar 2021 09:21:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FBE03858012; Wed, 31 Mar 2021 13:21:16 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 6C7323854809 for ; Wed, 31 Mar 2021 13:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C7323854809 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 89BE1AEB9; Wed, 31 Mar 2021 13:21:13 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Ignore DEBUGINFOD_URLS To: Simon Marchi , gdb-patches@sourceware.org References: <20210331123331.GA3054@delia> From: Tom de Vries Message-ID: <852e5449-00d5-001d-77d3-7e25e702428c@suse.de> Date: Wed, 31 Mar 2021 15:21:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/31/21 3:04 PM, Simon Marchi wrote: > On 2021-03-31 8:33 a.m., Tom de Vries wrote:> Hi, >> >> On openSUSE Tumbleweed, DEBUGINFOD_URLS is now defined by default: >> ... >> $ echo $DEBUGINFOD_URLS >> https://debuginfod.opensuse.org/ >> ... >> >> With DEBUGINFOD_URLS defined we run into: >> ... >> FAIL: gdb.mi/mi-sym-info.exp: List all functions from debug information only \ >> (timeout) >> ... >> as reported in PR27667. >> >> There's a latency of ~0.5s per request, which is ok-ish for interactive usage. >> But the symbol-info-functions command ends up issuing 21 source requests, >> which means we easily run into the 10s timeout. >> >> Fix this by unsetting DEBUGINFOD_URLS in default_gdb_init. >> >> Any comments? >> >> Thanks, >> - Tom >> >> [gdb/testsuite] Ignore DEBUGINFOD_URLS >> >> gdb/testsuite/ChangeLog: >> >> 2021-03-31 Tom de Vries >> >> PR testsuite/27667 >> * lib/gdb.exp (default_gdb_init): Unset DEBUGINFOD_URLS. >> >> --- >> gdb/testsuite/lib/gdb.exp | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 73fea3a104d..d18aec648d9 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -5270,6 +5270,10 @@ proc default_gdb_init { test_file_name } { >> # tests. >> setenv TERM "dumb" >> >> + # If DEBUGINFOD_URLS is set, gdb will try to download sources and >> + # debug info for f.i. system libraries. Prevent this. >> + unsetenv DEBUGINFOD_URLS >> + >> # Ensure that GDBHISTFILE and GDBHISTSIZE are removed from the >> # environment, we don't want these modifications to the history >> # settings. >> > > I think this is OK, we want to reduce external influence on the tests as > much as possible. > > However, I could imagine we could have a "debuginfod" board file, which > runs all tests with a controlled debuginfod server it spawns itself, and > it would set DEBUGINFOD_URLS accordingly. It could override gdb_compile > to feed all compiled binaries to the debuginfod server, something like > that. I also thought about that possibility. Anyway, such a board file could define something like: ... proc gdb_init { args } { set res [default_gdb_init {*}$args] setenv DEBUGINFOD_URLS "..." return $res } ... Committed, with the test for info exists env(DEBUGINFOD_URLS) added. Thanks, - Tom