Re: [PATCH] Warn about data-directory when failing to import Python "gdb" module

[Khoo Yit Phang <khooyp@cs.umd.edu>]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Hi Jan,

On Sep 22, 2012, at 9:30 AM, Jan Kratochvil wrote:

> ------------------------------------------------------------------------------
> Python Exception <type 'exceptions.ImportError'> No module named gdb: 
> 
> warning: Could not load the Python gdb module from `dfasdfsa/python'.
> You may need to provide the -data-directory flag to GDB.
> Limited Python support is available from the _gdb module.
> For more information about GDB dependencies on external files
> see the "Data Files" section in the GDB manual.  E.g., run from the shell:
> 	info "(gdb)Data Files"
> ------------------------------------------------------------------------------

Thanks for pointing out this style, it looks good to me, and it's nice to be consistent. I've updated my patch with it.

Yit
September 22, 2012


[-- Attachment #2: warn-gdb-python-compat.txt --]
[-- Type: text/plain, Size: 949 bytes --]

gdb/ChangeLog

2012-09-22  Khoo Yit Phang  <khooyp@cs.umd.edu>

	* gdb/python.c (finish_python_initialization): Augment the warning
	when importing "gdb" fails, to check that data-directory is set
	correctly.

diff --git a/gdb/python/python.c b/gdb/python/python.c
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1506,7 +1506,12 @@
       gdbpy_print_stack ();
       warning (_("Could not load the Python gdb module from `%s'."),
 		 gdb_pythondir);
-      warning (_("Limited Python support is available from the _gdb module."));
+      printf_filtered(_("\
+You may need to provide the -data-directory flag to GDB.\n\
+Limited Python support is available from the _gdb module.\n\
+For more information about GDB dependencies on external files\n\
+see the \"Data Files\" section in the GDB manual.  E.g., run from the shell:\n\
+\tinfo \"(gdb)Data Files\"\n"));
       do_cleanups (cleanup);
       return;
     }