From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138042-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 84414 invoked by alias); 5 Apr 2017 19:21:17 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 84402 invoked by uid 89); 5 Apr 2017 19:21:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 19:21:13 +0000
Received: by simark.ca (Postfix, from userid 33)	id 709311E81B; Wed,  5 Apr 2017 15:21:10 -0400 (EDT)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 1/2] ptid_{lwp,tid}_p: Remove unnecessary checks
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 05 Apr 2017 19:21:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
In-Reply-To: <15fd0842-2c1d-3567-f707-3de79fa84e67@redhat.com>
References: <20170404183235.10589-1-simon.marchi@ericsson.com> <15fd0842-2c1d-3567-f707-3de79fa84e67@redhat.com>
Message-ID: <85137e756398c3f6d0ac36826420f162@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.4
X-IsSubscribed: yes
X-SW-Source: 2017-04/txt/msg00126.txt.bz2

On 2017-04-05 11:15, Pedro Alves wrote:
> On 04/04/2017 07:32 PM, Simon Marchi wrote:
>> The calls to ptid_equal in ptid_lwp_p and ptid_tid_p that compare the
>> argument to minus_one_ptid and null_ptid are not necessary.  The calls
>> in question are:
>> 
>>    if (ptid_equal (minus_one_ptid, ptid)
>>        || ptid_equal (null_ptid, ptid))
>>      return 0;
>> 
>> minus_one_ptid is { .pid = -1, .lwp = 0, .tid = 0 }
>> null_ptid is { .pid = 0, .lwp = 0, .tid = 0 }
>> 
>> If the ptid argument is either of them, the statements
>> 
>>   return (ptid_get_lwp (ptid) != 0);
>> 
>> and
>> 
>>   return (ptid_get_tid (ptid) != 0);
>> 
>> will yield the same result (0/false).
>> 
>> gdb/ChangeLog:
>> 
>> 	* common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with
>> 	minus_one_ptid and null_ptid.
> 
> Indeed.  LGTM.
> 
> Thanks,
> Pedro Alves

Thanks, this one is pushed.