From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JrBhJ/k1dGopTAwAWB0awg (envelope-from ) for ; Thu, 06 Aug 2026 03:21:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=davNW6qY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mFvK3Vp+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oQI2Z3Q5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LmyeI33V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C09C1E033; Thu, 06 Aug 2026 03:21:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1B6821E033 for ; Thu, 06 Aug 2026 03:21:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5275F4BB3BEA for ; Thu, 6 Aug 2026 07:21:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5275F4BB3BEA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=davNW6qY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mFvK3Vp+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oQI2Z3Q5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LmyeI33V Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id D67D04B9DB6A for ; Thu, 6 Aug 2026 07:21:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D67D04B9DB6A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D67D04B9DB6A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786000864; cv=none; b=XBzbsNhQIzwHkd4L22M58aPYlB9m+BrWpXaqhVXLGDoRYIJy5eUf2WHMTJgIFKDH7LT1PRftQcj8ZmTFxcJIT4WVeVpskDko9HnSShyRjNrQvlBjzRs1SB5HI7Mnn3KTavDRECeIxPBZv6WmFceS7JKYE2sXkPu+Cj/sshYEFtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786000864; c=relaxed/simple; bh=opQzJC1U/8WgbMb3SoQWsvvTdPcJ+iuJG+EhPdBeYl0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Z+G11+nOyMyAEbqd//Ly/TgPvAPDzPKQqQ+bCrjvYUtiDI/42sb/pJMdiTMEZKJuTE3EbkQF/ELvd6QWssPHoorAnSyZLv+3/+mG7hDcdUtYTcT0YAWfR17kHy6wqf0cvNAL6sOHui07TkWWdBc+as77Xqzd4hvPvY6bd7oEC2g= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=davNW6qY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mFvK3Vp+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oQI2Z3Q5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LmyeI33V DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D67D04B9DB6A Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8C4B93DFF; Thu, 6 Aug 2026 07:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786000858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x86sgoGtQCLdZXfuUu1TidRaLBVDuw3RqU8hf5AA4qw=; b=davNW6qYiGX4fQkCSK/hiACvBmLGxZ5zFsON66FGx1Pteow3Dbw0b8fycTF/E+e5rkKTVU 9lDr5qNO6z5XfR7GDfWYAegxJ54ja6EY9D5PiJlpE0j1iGeS8SqH61c9xYH0/BgQG+xDgw Y1Z0sfhezVA1TI69QD/k0+Yv2RmjVhc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786000858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x86sgoGtQCLdZXfuUu1TidRaLBVDuw3RqU8hf5AA4qw=; b=mFvK3Vp+u4UNRJYurw+rcI4KQNOC7EB+Jl1Eab/Dwj+He9tz760pWKP4RLLjrLYy2AmplZ wNPCbU+r1eBgTUDw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786000854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x86sgoGtQCLdZXfuUu1TidRaLBVDuw3RqU8hf5AA4qw=; b=oQI2Z3Q5hygbeBntBocJRspYNlZhzwyeA0bNIy2KLilthdEPj3IAF2uGaSM7w2m62ILBT5 O8uchhZg/sgyQMyAJFlfJwzA/m+XlG+mwJs0pL3ZhdSmYwbX4kW3l1QcoM1uK1ldTKim+o +09JPritpu0DrOjncw7RYgiQrjShumc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786000854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x86sgoGtQCLdZXfuUu1TidRaLBVDuw3RqU8hf5AA4qw=; b=LmyeI33V53cVTyvBbhVkX5/2MeQgQWFJtxTe9zRL2DPeb3idVczlXCJyOhkXGjwIbEJV+e V8w6imUrk77IQiDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 73AA3779B6; Thu, 6 Aug 2026 07:20:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HJKBGtY1dGrqKgAAD6G6ig (envelope-from ); Thu, 06 Aug 2026 07:20:54 +0000 Message-ID: <8510f94a-ba35-41a5-b8b6-b258cca6f606@suse.de> Date: Thu, 6 Aug 2026 09:20:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove redundant check from check_types_equal To: Tom Tromey , gdb-patches@sourceware.org References: <20260805193723.175636-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260805193723.175636-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/5/26 9:37 PM, Tom Tromey wrote: > check_types_equal compares both is_nottext and instance_flags, but the > latter includes the former, so the redundant check can be removed. LGTM. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/gdbtypes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index f5c0177bff2..4b6c01910f4 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -4092,7 +4092,6 @@ check_types_equal (struct type *type1, struct type *type2, > || type1->endianity_is_not_default () != type2->endianity_is_not_default () > || type1->has_varargs () != type2->has_varargs () > || type1->is_vector () != type2->is_vector () > - || type1->is_nottext () != type2->is_nottext () > || type1->instance_flags () != type2->instance_flags () > || type1->num_fields () != type2->num_fields ()) > return false; > > base-commit: b7da195b94b423e5cfd27a14c636ffe9f7380cdd