From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ltttG42uhGWzBycAWB0awg (envelope-from ) for ; Thu, 21 Dec 2023 16:30:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703194253; bh=LJ/5Br6zSEDgM/bqKjehkGcGe2iYCK+zrfdFrHM5N6s=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HpXdiclp+R4pMDLki3btU2IKVtXeaZsQUOmWik7jl4LwTGnJHLUxENavubgNatDeK T2pyMxcUjD0Z5yro5wOi6l2EkJ8nUa2aIFLUJekCG+xFnvt7oyuSy40tgvHDvl/hzO xmjht631BF96d343BZTa5Igy8XU8q1mjao74qoWE= Received: by simark.ca (Postfix, from userid 112) id 61FE21E0C3; Thu, 21 Dec 2023 16:30:53 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=s2rcOPf4; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D48D1E0AC for ; Thu, 21 Dec 2023 16:30:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6341386EC59 for ; Thu, 21 Dec 2023 21:30:50 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A02A23858D37 for ; Thu, 21 Dec 2023 21:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A02A23858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A02A23858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194241; cv=none; b=k8Zk2UX8RmAsvwQhC3SF8qG1or3HgggveGvGeFCYetSsotVnmvfm2YyuDjgQl0+FmpmsX2vmUNALvsb/Zj4Yx78hpubPzL7gT2FEw+VC+5H2ayfdOe2Rzt2oK/9EnntbgY0Miz8KA0ket0OnrBrKt0dLNcu1P0i4rophSZUn0kU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703194241; c=relaxed/simple; bh=LJ/5Br6zSEDgM/bqKjehkGcGe2iYCK+zrfdFrHM5N6s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FTY6HleMwGdLC72MRgTrfrqQ2FukyaHVk86X8JF+t29NaOc09q7ctBCUJ3F3YqdLwmCCGqf+l+iYqTDz7jVmdcywQGE4ON4rgive+OKyOPyIIrCYsQe9Oppta+9jQzSTyO2zeAEsid5PBg8NO71bdczbZJpr2V2mpqMNzqe2JvQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703194240; bh=LJ/5Br6zSEDgM/bqKjehkGcGe2iYCK+zrfdFrHM5N6s=; h=Date:Subject:To:References:From:In-Reply-To:From; b=s2rcOPf4zBcuM8msVedwIwUeXSUvmNqXGOi/iHnmL55SjljdcuFoCwQOWGErFHRPs wy1trfPpBVyWY6Rw+YL9N8XYGZ2lOo3eKM0vtoqDejZNORexCu1GR7U6smAKBawTt6 KQjQyRWGiK8UfbKFUFbz+tqBCBsuC4qjRHwpSJAU= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 345151E0AC; Thu, 21 Dec 2023 16:30:40 -0500 (EST) Message-ID: <84ebb893-1bdc-47c3-8bae-757489208d75@simark.ca> Date: Thu, 21 Dec 2023 16:30:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/26] gdbserver: introduce and use regcache::set_register_status Content-Language: fr To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <89ffb94330c3f96b34e00a653ebbfce99a075c42.1677582744.git.tankut.baris.aktemur@intel.com> From: Simon Marchi In-Reply-To: <89ffb94330c3f96b34e00a653ebbfce99a075c42.1677582744.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote: > Introduce and use a setter method in regcache to set the status of a > register. There already exists get_register_status. So, it made > sense to add the setter to control access to the register_status > field. Does this method (and eventually the register_status field) need to be public? Or is it only set internally, through some other methods? > @@ -498,6 +495,16 @@ regcache::get_register_status (int regnum) const > #endif > } > > +void > +regcache::set_register_status (int regnum, enum register_status status) > +{ > +#ifndef IN_PROCESS_AGENT > + gdb_assert (regnum >= 0 && regnum < tdesc->reg_defs.size ()); > + if (register_status != nullptr) > + register_status[regnum] = status; > +#endif I don't understand why some spots (like here) check for register_status being nullptr, but others (like get_register_status) don't. Simon