From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57615 invoked by alias); 8 Feb 2020 16:16:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57560 invoked by uid 89); 8 Feb 2020 16:16:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=gdblog, gdb.log, UD:gdb.log X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Feb 2020 16:16:17 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CEA871E08E; Sat, 8 Feb 2020 11:16:09 -0500 (EST) Subject: Re: [PATCH][gdb/testsuite] Capture many-headers.exp progress and output in gdb.log To: Tom de Vries , gdb-patches@sourceware.org References: <20200206085252.GA2453@delia> From: Simon Marchi Message-ID: <84cdebc1-4bd6-1017-6916-6cbd78b466d7@simark.ca> Date: Sat, 08 Feb 2020 16:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200206085252.GA2453@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00232.txt.bz2 On 2020-02-06 3:52 a.m., Tom de Vries wrote: > Hi, > > When running test-case gdb.base/many-headers.exp, we have test output on > stdout/stderr: > ... > Running src/gdb/testsuite/gdb.base/many-headers.exp ... > [New LWP 759] > Core was generated by `outputs/gdb.base/many-headers/many'. > Program terminated with signal SIGSEGV, Segmentation fault. > \#0 0x0000000000400688 in ?? () > > === gdb Summary === > > nr of expected passes 1 > ... > > Furthermore, the only trace in gdb.log that we have of the gdb command issued > is: > ... > PASS: gdb.base/many-headers.exp: read core file > ... > > Fix this by echoing the gdb command in gdb.log, and capturing the > command output and pasting it into gdb.log: > ... > ( ulimit -s 4096; \ > gdb -nw -nx -data-directory data-directory -batch -core=many-headers.core ) > [New LWP 1542] > Core was generated by `many'. > Program terminated with signal SIGSEGV, Segmentation fault. > \#0 0x0000000000400688 in ?? () > PASS: gdb.base/many-headers.exp: read core file > ... > > Tested on x86_64-linux. > > OK for trunk? > > Thanks, > - Tom > > [gdb/testsuite] Capture many-headers.exp progress and output in gdb.log > > gdb/testsuite/ChangeLog: > > 2020-02-06 Tom de Vries > > * gdb.base/many-headers.exp: Echo gdb command to gdb.log. Capture gdb > command output and paste it into gdb.log. If any, paste catch message > to gdb.log. > > --- > gdb/testsuite/gdb.base/many-headers.exp | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp > index dc7f8675b8..3c2a4dc91b 100644 > --- a/gdb/testsuite/gdb.base/many-headers.exp > +++ b/gdb/testsuite/gdb.base/many-headers.exp > @@ -51,17 +51,24 @@ if { "$msg" != "" } { > return -1 > } > > +set cmd \ > + [concat \ > + "(" \ > + "ulimit -s $stack_limit;" \ > + "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS -batch -core=$corefile" \ > + ")"] > +verbose -log $cmd > + > # Run gdb with stack limit > catch { > - system [concat \ > - "(" \ > - "ulimit -s $stack_limit;" \ > - "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS -batch -core=$corefile" \ > - ")"] > + system "$cmd > OUTPUT 2>&1" > } msg > +verbose -log [exec cat OUTPUT] > + > set test "read core file" > if { "$msg" == "" } { > pass "$test" > } else { > + verbose -log $msg > fail "$test" > } > This leaves a stray OUTPUT file in the build/gdb/testsuite directory. I am fine with the technique used, but maybe just create some file using standard_output_file? Simon