From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50288-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8105 invoked by alias); 13 Aug 2007 22:25:53 -0000
Received: (qmail 8062 invoked by uid 22791); 13 Aug 2007 22:25:52 -0000
X-Spam-Check-By: sourceware.org
Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 22:25:49 +0000
Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) 	by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l7DMPkAF003323; 	Mon, 13 Aug 2007 15:25:46 -0700
Received: from 12.7.175.2         (SquirrelMail authenticated user msnyder)         by webmail.sonic.net with HTTP;         Mon, 13 Aug 2007 15:25:46 -0700 (PDT)
Message-ID: <8461.12.7.175.2.1187043946.squirrel@webmail.sonic.net>
In-Reply-To: <m3ir7junr3.fsf@codesourcery.com>
References: <25041.12.7.175.2.1186865595.squirrel@webmail.sonic.net>     <m3ir7junr3.fsf@codesourcery.com>
Date: Mon, 13 Aug 2007 22:25:00 -0000
Subject: Re: [PATCH] source.c, find_source_lines
From: msnyder@sonic.net
To: "Jim Blandy" <jimb@codesourcery.com>
Cc: gdb-patches@sourceware.org
User-Agent: SquirrelMail/1.4.9a
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00261.txt.bz2

>
> msnyder@sonic.net writes:
>> Since 's' is repeatedly assumed, let's assert it rather than
>> sometimes checking it and sometimes not.
>
> Yeah... I don't see what this function would even be intended to do
> when passed NULL.

Thanks, committed.