From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YHhcHKaOlmJOkgkAWB0awg (envelope-from ) for ; Tue, 31 May 2022 17:54:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 64CEC1E221; Tue, 31 May 2022 17:54:46 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=vJW5AQNR; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9FF4D1E00D for ; Tue, 31 May 2022 17:54:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1720B383569A for ; Tue, 31 May 2022 21:54:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1720B383569A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654034084; bh=RYCVoyGjaJMXwCS20EF1XkElVNMSXf7YbK+DZNIN68A=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vJW5AQNRHfbV/PXqrpkZPVnxNNIF1XbECXhekeApOy3Y/woJp7CTshaQKd6shLSoj 4xuD1MmPuu9KJ7QAWOkqFYQ3kl62hXyLLsw49H7P6dpvq70b/CfO13Gu6UUkHEYgTA jWlnDrPdxB8wu54Cp+rByA0xTOp2w+PraXrUmQrw= Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 66251383569D for ; Tue, 31 May 2022 21:54:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66251383569D Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VKtfkD025926; Tue, 31 May 2022 21:54:15 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gdrhs3hr4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 21:54:14 +0000 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24VLZV5e003156; Tue, 31 May 2022 21:54:14 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gdrhs3hqx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 21:54:14 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24VLaFT0001965; Tue, 31 May 2022 21:54:13 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma04dal.us.ibm.com with ESMTP id 3gd4n5h6fg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 21:54:13 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24VLsCIn29229378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 May 2022 21:54:12 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AEB806E054; Tue, 31 May 2022 21:54:12 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 702246E04E; Tue, 31 May 2022 21:54:12 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.159.220]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 31 May 2022 21:54:12 +0000 (GMT) Message-ID: <8457aaf504438e99371cfa8f2f363cfe73da6786.camel@us.ibm.com> Subject: Re: [PATCH 2/2] gdb/python: improve formatting of help text for user defined commands To: Andrew Burgess , Tom Tromey , Andrew Burgess via Gdb-patches Date: Tue, 31 May 2022 14:54:12 -0700 In-Reply-To: <874k1aezlr.fsf@redhat.com> References: <58a7e3085365af2ac05409b78f6d15bf5240cd2c.1652784658.git.aburgess@redhat.com> <874k1njg8b.fsf@redhat.com> <87ee0g6vbm.fsf@tromey.com> <874k1aezlr.fsf@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2DRaTZxmvf6l_C2KpW9cyX4e16Jv1puI X-Proofpoint-GUID: NJG5TfQF3SRVWcHxWIFWUURi_3cDDbwW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_07,2022-05-30_03,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 clxscore=1011 mlxscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205310094 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Andrew: On Sat, 2022-05-28 at 11:11 +0100, Andrew Burgess via Gdb-patches wrote: > Tom Tromey writes: > > > > > > > > "Andrew" == Andrew Burgess via Gdb-patches < > > > > > > > gdb-patches@sourceware.org> writes: > > > > Andrew> Thanks to Eli and Lancelot for their feedback. > > > > Andrew> In this revision I have: > > Andrew> - Updated the NEWS entry in line with Eli's feedback, > > Andrew> - Updated some comments that Lancelot identified as being > > out of date, > > Andrew> - Added an additional comment into the test script to > > justify some > > Andrew> 'verbose -log' lines. > > Andrew> - There's no functional change to the code. > > > > This looks ok to me, thank you. > > Thanks, pushed. > > Andrew > I am seeing failures with the new test gdb/testsuite/gdb.python/py-doc- reformat.exp on X86-64 and Power. The errors show up in the full regression run and when just this test is run. When running just this test I see in the gdb/testsuite/gdb.log file the following issues. There are a couple of errors about "Undefined command "source /home/...". Then later I see the a series of FAILS for numerous tests. .... (gdb) set height 0 (gdb) set width 0 (gdb) dir Reinitialize source path to empty? (y or n) y Source directories searched: $cdir:$cwd (gdb) dir /home/carll/GDB/build-current/gdb/testsuite/../../../binutils-gdb-current/gdb/testsuite/gdb.python Source directories searched: /home/carll/GDB/build-current/gdb/testsuite/../../../binutils-gdb-current/gdb/testsuite/gdb.python:$cdir:$cwd (gdb) source /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.python/py-doc-reformat/py-doc-reformat-0.py /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.python/py-doc-reformat/py-doc-reformat-0.py:1: Error in sourced command file: Undefined command: "class". Try "help". (gdb) ERROR: Undefined command "source /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.python/py-doc-reformat/py-doc-reformat-0.py". UNRESOLVED: gdb.python/py-doc-reformat.exp: test 0: source python command file help test-cmd Undefined command: "test-cmd". Try "help". (gdb) ERROR: Undefined command "help test-cmd". UNRESOLVED: gdb.python/py-doc-reformat.exp: test 0: help test-cmd help set test-param Evaluate expression EXP and assign result to variable VAR. Usage: set VAR = EXP This uses assignment syntax appropriate for the current language (VAR = EXP or VAR := EXP for example). VAR may be a debugger "convenience" variable (names starting with $), a register (a few standard names starting with $), or an actual variable in the program being debugged. EXP is any valid expression. Use "set variable" for variables with names identical to set subcommands. With a subcommand, this command modifies parts of the gdb environment. You can see these environment settings with the "show" command. List of set subcommands: set ada -- Prefix command for changing Ada-specific settings. ... set use-deprecated-index-sections -- Set whether to use deprecated gdb_index sections. set variable, set var -- Evaluate expression EXP and assign result to variable VAR. set verbose -- Set verbosity. set watchdog -- Set watchdog timer. set width -- Set number of characters where GDB should wrap lines of its output. set write -- Set writing into executable and core files. Type "help set" followed by set subcommand name for full documentation. Type "apropos word" to search for commands related to "word". Type "apropos -v word" for full documentation of commands related to "word". Command name abbreviations are allowed if unambiguous. (gdb) FAIL: gdb.python/py-doc-reformat.exp: test 1: help set test-param help show test-param Undefined show command: "test-param". Try "help show". (gdb) FAIL: gdb.python/py-doc-reformat.exp: test 1: help show test-param Start of: test_cmd 2 ... Note, these two failures for test 1, repeat for each of the following tests 10, 11, 12, 13, 14, 15, 16, 17, 18. ... Input: """ This is the first line. Indented second line. This is the third line.""" builtin_spawn /home/carll/bin/gdb -nw -nx -iex set height 0 -iex set width 0 GNU gdb (GDB) 13.0.50.20220529-git ... === gdb Summary === # of unexpected failures 44 # of unresolved testcases 44 Then final error count across all of the tests is 44. I tried doing the commands manually: (gdb) help set test-param <- this should be test 1, which in the regression run is listed as a failure but seemed to work manually. Wondering if there is an issue in the error reporting. Evaluate expression EXP and assign result to variable VAR. Usage: set VAR = EXP This uses assignment syntax appropriate for the current language (VAR = EXP or VAR := EXP for example). VAR may be a debugger "convenience" variable (names starting with $), a register (a few standard names starting with $), or an actual variable in the program being debugged. EXP is any valid expression. Use "set variable" for variables with names identical to set subcommands. With a subcommand, this command modifies parts of the gdb environment. You can see these environment settings with the "show" command. List of set subcommands: set ada -- Prefix command for changing Ada-specific settings. set agent -- Set debugger's willingness to use agent as a helper. set annotate -- Set annotation_level. set architecture, set processor -- Set architecture of target. set args -- Set argument list to give program being debugged when it is started. set auto-connect-native-target -- Set whether GDB may automatically connect to the native target. set auto-load -- Auto-loading specific settings. set auto-solib-add -- Set autoloading of shared library symbols. set backtrace -- Set backtrace specific variables. set basenames-may-differ -- Set whether a source file may have multiple base names. set breakpoint -- Breakpoint specific settings. set can-use-hw-watchpoints -- Set debugger's willingness to use watchpoint hardware. set case-sensitive -- Set case sensitivity in name search (on/off/auto). set charset -- Set the host and target character sets. set check, set ch, set c -- Set the status of the type/range checker. set circular-trace-buffer -- Set target's use of circular trace buffer. set code-cache -- Set cache use for code segment access. set coerce-float-to-double -- Set coercion of floats to doubles when calling functions. set compile-args -- Set compile command GCC command-line arguments. set compile-gcc -- Set compile command GCC driver filename. set complaints -- Set max number of complaints about incorrect symbols. set confirm -- Set whether to confirm potentially dangerous operations. set cp-abi -- Set the ABI used for inspecting C++ objects. set cwd -- Set the current working directory to be used when the inferior is started. set data-directory -- Set GDB's data directory. set dcache -- Use this command to set number of lines in dcache and line-size. set debug -- Generic command for setting gdb debugging flags. set debug-file-directory -- Set the directories where separate debug symbols are searched for. set debuginfod -- Set debuginfod options. set default-collect -- Set the list of expressions to collect by default. set demangle-style -- Set the current C++ demangling style. set detach-on-fork -- Set whether gdb will detach the child of a fork. set directories -- Set the search path for finding source files. set disable-randomization -- Set disabling of debuggee's virtual address space randomization. set disassemble-next-line -- Set whether to disassemble next source line or insn when execution stops. --Type for more, q to quit, c to continue without paging--q Quit (gdb) help show test-param Undefined show command: "test-param". Try "help show". <- failure I haven't found any specific system setup errors to explain the fails. Please let me know if I can help further with these failures. Carl Love