From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-147840-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5584 invoked by alias); 31 May 2018 14:59:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5536 invoked by uid 89); 31 May 2018 14:59:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 14:59:30 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 4062140201A0;	Thu, 31 May 2018 14:59:29 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 9C59663F3D;	Thu, 31 May 2018 14:59:28 +0000 (UTC)
Subject: Re: [PATCH 4/8] Enable SVE for GDB
To: Alan Hayward <alan.hayward@arm.com>, gdb-patches@sourceware.org
References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-5-alan.hayward@arm.com>
Cc: nd@arm.com
From: Pedro Alves <palves@redhat.com>
Message-ID: <8455164b-72c9-61d5-17c0-c77304d588ce@redhat.com>
Date: Thu, 31 May 2018 16:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180511105256.27388-5-alan.hayward@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-05/txt/msg00859.txt.bz2

On 05/11/2018 11:52 AM, Alan Hayward wrote:
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2873,6 +2873,26 @@ aarch64_read_description (long vq)
>    return tdesc;
>  }
>  
> +/* Return the VQ used when creating the target description TDESC.  */
> +
> +static long
> +aarch64_get_tdesc_vq (const struct target_desc *tdesc)

Is this use of "long" significant?  I mean, is it assuming 64-bit?
I ask because longs are not 64-bit on x64 Windows, so it would
do the wrong thing when cross debugging.

> +{
> +  const struct tdesc_feature *feature_sve;
> +
> +  if (!tdesc_has_registers (tdesc))
> +    return 0;
> +

Thanks,
Pedro Alves