From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93062 invoked by alias); 17 Mar 2019 16:46:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93053 invoked by uid 89); 17 Mar 2019 16:46:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=hat, UD:So, H*c:PHrt, H*RU:sk:sonic31 X-HELO: sonic314-19.consmr.mail.ir2.yahoo.com Received: from sonic314-19.consmr.mail.ir2.yahoo.com (HELO sonic314-19.consmr.mail.ir2.yahoo.com) (77.238.177.145) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Mar 2019 16:46:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1552841201; bh=PEM+af+X2qm/XqmuYaT5AzkFSWm7m+mFjLFm705HAEs=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=cWOkt7mA8TB5qzWuxkK53RABHAcmtLIPDARkXAkXSWpMhO194Q3sxHkkYBjHkQcLwOLUxM0cRgJFOMHkLhcasIAJUK7ljpe7ANG0S76eNB3iDt8gR61aBlfzVBC+QMS8CR/M8ILzOLmc0f3TRkFLaBFTnGajRvdiNDIKznTb1yOT6U8YxFniKjJNB751M7HNcPHr2kaRu8510kLPoRvtWcysZ08CiV2uqgUJbl87IhS7ASY4xQeX67yYC64Ul9VkbWwMW8dYyN2LVrBtRw8t2UW3i/i/jUbfivOabKv4ueEGLXIfjZod0N9BTqFmHisYQuEGvgTyWK+sRAUkwrZdxA== Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sun, 17 Mar 2019 16:46:41 +0000 Date: Sun, 17 Mar 2019 16:46:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: GDB Patches Message-ID: <844158233.10369297.1552841197833@mail.yahoo.com> In-Reply-To: <83r2b5wkl5.fsf@gnu.org> References: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> <186859064.9289078.1552667917410@mail.yahoo.com> <83r2b5wkl5.fsf@gnu.org> Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00349.txt.bz2 Am Sonntag, 17. M=C3=A4rz 2019, 17:07:46 MEZ hat Eli Zaretskii Folgendes geschrieben:=20 > > Date: Fri, 15 Mar 2019 16:38:37 +0000 (UTC)> > From: "Hannes Domani via= gdb-patches" > > > > Also, I had to add the fo= llowing to make it work on windows> > (but beware, I'm using pdcurses, not = ncurses, and I don't know if ncurses> > for windows needs this as well):> > Ncurses doesn't need this.> > > > --- a/gdb/tui/tui-io.c> > +++ b/gdb/tui/tui-io.c> > @@ -369,6 +386,17 @= @ apply_ansi_escape (WINDOW *w, const char *buf)> > > > =C2=A0=C2=A0 if (re= verse_mode_p)> > =C2=A0=C2=A0=C2=A0=C2=A0 {> > +#if defined(__MINGW32__)> >= +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (style.get_foreground ().is_basic ()> >= +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && style.get_foreground = ().get_value ()> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D=3D= (ncurses_norm_attr & 15))> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 style.s= et_fg (ui_file_style::NONE);> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (style.g= et_background ().is_basic ()> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 && style.get_background ().get_value ()> > +=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 =3D=3D ((ncurses_norm_attr >> 4) & 15))> > +=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 style.set_bg (ui_file_style::NONE);> > +#end= if> > +> > Could you describe what happens with pdcurses if you don't make this> cha= nge?=C2=A0 It's strange that pdcurses cannot use explicit color> specificat= ion if the color is the default one. Actually, you can disregard that. Before you added that fix for windows, I found a different workaround,it wa= s to set the "normal" color in esc.style to gray. I forgot that I did that, and it backfired now.So I removed that again, and= everything is fine now even without that above change. Sorry for the noise. RegardsHannes Domani