From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/9] Fix most -fgnat-encodings=minimal failures
Date: Wed, 4 Nov 2020 17:33:22 +0100 [thread overview]
Message-ID: <841f46d8-6f6a-0b89-a99f-6077300e849f@suse.de> (raw)
In-Reply-To: <87wnz1jf61.fsf@tromey.com>
On 11/4/20 4:49 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
>
> Tom> GNAT has two debuginfo modes -- the default, which is to emit "GNAT
> Tom> encodings", and -fgnat-encodings=minimal, which emits something closer
> Tom> to pure DWARF.
>
> Tom> Historically gdb has only handled GNAT encodings. This patch series
> Tom> brings gdb most of the way to handling -fgnat-encodings=minimal. The
> Tom> remaining issues are going to require some patches to GNAT and gdb; my
> Tom> plan is to only land the gdb changes once the GNAT changes have gone
> Tom> in.
>
> Tom> Patches #2 - #9 were all reviewed internally by Joel. However, they
> Tom> aren't all purely Ada-specific. (Patch #1 is new, written while I was
> Tom> prepping this series -- see the comments there.)
>
> Tom> For gdb itself, the benefit of these changes is that with
> Tom> minimal-encodings, the Ada type system works more like the rest of
> Tom> gdb. For users the main benefit is that the Python API works more
> Tom> nicely.
>
> I'm checking these in now.
With a build from commit d8f62e8447 "Recognize names of array types", I get:
...
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
element
FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print first array
slice
FAIL: gdb.ada/big_packed_array.exp: scenario=minimal: print bad
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype small (PRMS
minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small (PRMS
minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print small'first
(PRMS minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: ptype multi (PRMS
minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi (PRMS
minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi'first
(PRMS minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print multi_multi
(PRMS minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print
multi_multi(1,3) (PRMS minimal encodings)
KPASS: gdb.ada/enum_idx_packed.exp: scenario=minimal: print
multi_multi(2) (PRMS minimal encodings)
KPASS: gdb.ada/mod_from_name.exp: scenario=minimal: print xp (PRMS
minimal encodings)
KPASS: gdb.ada/pckd_arr_ren.exp: scenario=minimal: print var (PRMS
minimal encodings)
...
Thanks,
- Tom
next prev parent reply other threads:[~2020-11-04 16:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 20:05 Tom Tromey
2020-09-30 20:05 ` [PATCH 1/9] Avoid crash in ada-lang.c:to_fixed_array_type Tom Tromey
2020-09-30 20:05 ` [PATCH 2/9] Fix decoding of multi-dimensional constrained packed arrays Tom Tromey
2020-09-30 20:05 ` [PATCH 3/9] Synthesize array descriptors with -fgnat-encodings=minimal Tom Tromey
2020-11-06 12:08 ` Luis Machado via Gdb-patches
2020-11-06 17:55 ` Tom Tromey
2020-09-30 20:05 ` [PATCH 4/9] Reject slicing a packed array Tom Tromey
2020-09-30 20:05 ` [PATCH 5/9] Resolve dynamic type in ada_value_struct_elt Tom Tromey
2020-09-30 20:05 ` [PATCH 6/9] Fix bit strides for -fgnat-encodings=minimal Tom Tromey
2020-09-30 20:05 ` [PATCH 7/9] Only use stride for final element type Tom Tromey
2020-09-30 20:05 ` [PATCH 8/9] Use bit stride when taking slice of array Tom Tromey
2020-09-30 20:06 ` [PATCH 9/9] Recognize names of array types Tom Tromey
2020-11-04 15:49 ` [PATCH 0/9] Fix most -fgnat-encodings=minimal failures Tom Tromey
2020-11-04 16:33 ` Tom de Vries [this message]
2020-11-04 17:20 ` Tom de Vries
2020-11-04 18:52 ` Tom Tromey
2020-11-04 19:54 ` Tom de Vries
2020-11-16 14:32 ` Tom de Vries
2020-11-16 14:01 ` [PATCH][gdb/testsuite] Fix minimal encodings KPASSes Tom de Vries
2020-11-23 19:10 ` [committed][gdb/testsuite] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841f46d8-6f6a-0b89-a99f-6077300e849f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox