From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63905-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14500 invoked by alias); 21 May 2009 18:33:05 -0000
Received: (qmail 14491 invoked by uid 22791); 21 May 2009 18:33:04 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 May 2009 18:33:00 +0000
Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KK000800B9GLN00@i_mtaout3.012.net.il> for gdb-patches@sources.redhat.com; Thu, 21 May 2009 21:32:57 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.115.215]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KK0004LBBIWWMM0@i_mtaout3.012.net.il>; Thu, 21 May 2009 21:32:57 +0300 (IDT)
Date: Thu, 21 May 2009 18:33:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Python pretty-printing [6/6]
In-reply-to: <m3k54axr5o.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: vladimir@codesourcery.com, gdb-patches@sources.redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zld6nw6b.fsf@gnu.org>
References: <m37i22bwoq.fsf@fleche.redhat.com> <loom.20090518T052234-940@post.gmane.org> <m3my9a0yvg.fsf@fleche.redhat.com> <m3k54axr5o.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00468.txt.bz2

> Cc: gdb-patches@sources.redhat.com
> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 21 May 2009 12:11:15 -0600
> 
> It also has a small documentation change, to explain the rationale for
> the Python API.

Thanks.  The documentation change is approved, with the following
minor comment:

> +If not @samp{None}, @var{visualizer} must be a Python expression.
> +This expression must evaluate to a callable object which accepts a
> +single argument.  @value{GDBN} will call this object with the value of
> +the varobj @var{name} as an argument (this is done so that the same
> +Python pretty-printing code can be used for both the CLI and MI).
> +This function must return an object which conforms to the
> +pretty-printing interface (@pxref{Pretty Printing}).

You said VISUALIZER must evaluate to an _object_ that GDB will call,
but now you are saying that the _function_ must return something.
Suggest to say "When called, this object must return ...", to avoid
confusion about how did we get to a function.

OK with that change.