From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23855 invoked by alias); 6 Jul 2009 20:29:54 -0000 Received: (qmail 23847 invoked by uid 22791); 6 Jul 2009 20:29:54 -0000 X-SWARE-Spam-Status: No, hits=0.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout4.012.net.il (HELO mtaout3.012.net.il) (84.95.2.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jul 2009 20:29:44 +0000 Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KMD00100NF4ES00@i_mtaout3.012.net.il> for gdb-patches@sourceware.org; Mon, 06 Jul 2009 23:29:32 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.249.41]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KMD004TZNL65MK0@i_mtaout3.012.net.il>; Mon, 06 Jul 2009 23:29:31 +0300 (IDT) Date: Mon, 06 Jul 2009 20:29:00 -0000 From: Eli Zaretskii Subject: Re: Reporting the OSABI in target descriptions. In-reply-to: <200907061617.58494.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83zlbhzhas.fsf@gnu.org> References: <200906102219.47898.pedro@codesourcery.com> <200907061617.58494.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00164.txt.bz2 > From: Pedro Alves > Date: Mon, 6 Jul 2009 16:17:58 +0100 > Cc: Eli Zaretskii > > > So that gdbserver supports this, I've tweaked the regformats/regdat.sh > > script to grok a new "osabi" field in the .dat files, and done > > a couple of examples: x86/x86_64-linux, which covers the specifying > > the osabi in the .dat files directly, and mips-linux, that covers doing > > it in from an embedded xml file. I didn't touch other archs as their > > xml and dat files didn't have "linux" in the filename, but > > it probably just means that we'd have to go add such linux files, > > or check which ones aren't named foolinux.xml or foolinux.dat, > > but are only really used by gdbserver-linux. Sorry, I don't follow: why just Linux? > > We can of course > > easilly add .xml and .dat files for Windows or other hosts > > gdbserver runs on. Perhaps we should indeed add that for the popular platforms. > Eli, are is the docs (mostly doing the same as the description of > the "architecture" element does) and NEWS patch hunks below okay? Yes, with a couple of comments: > +* Target descriptions can now describe the target OS ABI. See the > +section on target descriptions in the user manual for more > +information. In fact is described in "Target Description Format", not in "Target Descriptions". So maybe use the exact section name here. > +@cindex "" is a kind of symbol, so it's better to have it in @code. > +An @samp{} element has this form: > + > +@smallexample > + @var{osabi} > +@end smallexample > + > +@var{osabi} is an OS ABI name from the same selection accepted by Using "osabi" both for the tag and the OS ABI name could confuse the reader. Suggest to use "abi" or "abi-name" for the latter. Thanks.