From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69985-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15642 invoked by alias); 4 Feb 2010 22:20:24 -0000
Received: (qmail 15633 invoked by uid 22791); 4 Feb 2010 22:20:24 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 22:20:19 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KXC005008J1M600@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 05 Feb 2010 00:20:16 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXC0037D8PRR750@a-mtaout22.012.net.il>; Fri, 05 Feb 2010 00:20:16 +0200 (IST)
Date: Thu, 04 Feb 2010 22:20:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] doc addition to gdbint.texinfo
In-reply-to: <20100204213709.C7D4884414@ruffy.mtv.corp.google.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zl3ofxsw.fsf@gnu.org>
References: <20100204213709.C7D4884414@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00144.txt.bz2

> Date: Thu,  4 Feb 2010 13:37:09 -0800 (PST)
> From: dje@google.com (Doug Evans)
> 
> The Testsuite section of gdbint.texinfo is missing docs on at least
> two more DejaGnu variables that are available to be overridden:
> GDB, GDBSERVER.
> 
> Since there's at least three of them (those two plus TRANSCRIPT),
> with more to come, it seemed appropriate to create a new section to
> document them all.

I agree.

> Ok to check in?

Yes, after this:

> +Several variables exist to modify the behavior of the testsuite.
> +
> +@itemize @bullet
> +
> +@item TRANSCRIPT

Please give each variable the @code markup.

> +@smallexample
> +make check RUNTESTFLAGS="GDB=/usr/bin/gdb GDBSERVER=/usr/bin/gdbserver"
> +@end smallexample

Did you try to "make pdf"?  I suspect that this line is too long and
will overflow the right margin.  If it does, please break it into two
(and tell in the text that it is just one long line).

> +The second is to cd to the @file{testsuite} directory and invoke the DejaGnu
> +@kbd{runtest} command directly.

In this context, "runtest" is a name of a command, not a command line
typed at the keyboard.  So @command will be more appropriate than @kbd
here.

OK with these changes.

Thanks.