From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73893-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7168 invoked by alias); 22 Jun 2010 18:05:45 -0000
Received: (qmail 7159 invoked by uid 22791); 22 Jun 2010 18:05:44 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jun 2010 18:05:39 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L4F00H00GI0SF00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 22 Jun 2010 21:05:22 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.178.198]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L4F00CQMGWXFQD0@a-mtaout23.012.net.il>; Tue, 22 Jun 2010 21:05:22 +0300 (IDT)
Date: Tue, 22 Jun 2010 18:05:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Let "gcore" command accept a suffix argument
In-reply-to: <AANLkTilS_akNAsRbtukpkx7FgHb5u-Rsb5JkYfGvxrI9@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: tromey@redhat.com, brobecker@adacore.com, stanshebs@earthlink.net, stan@codesourcery.com, msnyder@vmware.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zkyndjx2.fsf@gnu.org>
References: <m31vioaxv0.fsf@fleche.redhat.com> <4B3BEDCC.9040103@earthlink.net> <daef60381001040642h2e8b3919u221f61d43b23d395@mail.gmail.com> <daef60381001052257q2068a8fbmaacd026b8d5cef49@mail.gmail.com> <20100106075757.GF24777@adacore.com> <daef60381001090154m36f5cf15x9f76b7073e4d126@mail.gmail.com> <20100109105557.GA2007@adacore.com> <daef60381001090717j4a658548g114950986df6279b@mail.gmail.com> <20100110054328.GD2007@adacore.com> <daef60381001100530k39fe9727s355cad73a47a2989@mail.gmail.com> <20100110140029.GF2007@adacore.com> <AANLkTinVPdwg6HuAp08wknw8DYe80LcR33tbEaRkMDXz@mail.gmail.com> <m3wrtsf4l7.fsf@fleche.redhat.com> <AANLkTilS_akNAsRbtukpkx7FgHb5u-Rsb5JkYfGvxrI9@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00486.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Tue, 22 Jun 2010 15:29:03 +0800
> Cc: Stan Shebs <stanshebs@earthlink.net>, Stan Shebs <stan@codesourcery.com>, 
> 	Michael Snyder <msnyder@vmware.com>, gdb-patches ml <gdb-patches@sourceware.org>
> 
> I make a new patch according to your mails.
> 
> It include the code, doc and test.  Please help me review it.

Thanks.  The doc parts are okay, with these two comments:

> +eval template, expressions...
> +  Convert the values of one or more expressions under the control
> +  of the string template to a command line and call it.
                                             ^
A comma here, please.

> +@item eval @var{template}, @var{expressions}@dots{}
> +Convert the values of one or more @var{expressions} under the control of
> +the string @var{template} to a command line and call it.
                                              ^
Same here.