Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFA/doco] document support for Ravenscar profile
Date: Thu, 23 Sep 2010 23:55:00 -0000	[thread overview]
Message-ID: <83zkv8tcx8.fsf@gnu.org> (raw)
In-Reply-To: <1285272848-15942-1-git-send-email-brobecker@adacore.com>

> From: Joel Brobecker <brobecker@adacore.com>
> Cc: Joel Brobecker <brobecker@adacore.com>
> Date: Thu, 23 Sep 2010 13:14:08 -0700
> 
> This announces the support for debugging Ada programs using
> the Ravenscar Profile, as well as documents the new commands
> introduced as part of this effort.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 01d2f46..c982caf 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -67,6 +67,9 @@
>    ** GDBserver is now supported on PowerPC LynxOS (versions 4.x and 5.x),
>       and i686 LynxOS (version 5.x).
>  
> +* Ada task switching is now supported on sparc-elf targets when
> +  debugging a program using the Ravenscar Profile.

This part is okay, but please add a sentence pointing to the new
section in the manual which describes the details.

> +@node The Ravenscar Profile

I'd prefer to remove "The" from the node name.

> +The @dfn{Ravenscar Profile} is a subset of the Ada tasking features,
> +specifically designed for systems with safety-critical real-time
> +requirements. With GNAT, the activation of this profile requires
               ^^
Two spaces, please.

> +the use of a specific Runtime.

Is this important to mention this specific runtime?  If it is
important, then is it enough to just mention its necessity, without
any further details?  And why "Runtime" with a capital R?

> +
> +@table @code
> +@kindex set ravenscar task-switching on
> +@cindex enable task switching with program using Ravenscar Profile
> +@item set ravenscar task-switching on
> +Allows task switching when debugging a program that uses the Ravenscar
> +Profile.  This is the default.
> +
> +@kindex set ravenscar task-switching off
> +@cindex disable task switching with program using Ravenscar Profile

Instead of 2 @cindex entries, I'd just leave one:

  @cindex task switching with program using Ravenscar Profile

WDYT?

> +@item set ravenscar task-switching off
> +Turn off task switching when debugging a program that uses the Ravenscar
> +Profile.  This is mostly intended to help disable the code that adds

"help disable" or "disable"?  That is, is this only part of what's
needed to disable Ravenscar Profile support, or is it the whole thing?

> +properly.  To be completely effective, this command should be run
> +before the program is started.

Will it be even partially effective if it is run after the program is
started?  If not, then I think we should drop the "completely" part.

Okay with those gotchas fixed.


  reply	other threads:[~2010-09-23 22:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 22:37 Joel Brobecker
2010-09-23 23:55 ` Eli Zaretskii [this message]
2010-09-23 23:20   ` Joel Brobecker
2010-09-24 14:42     ` Eli Zaretskii
2010-09-29 10:17     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zkv8tcx8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox