From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27261 invoked by alias); 19 Feb 2011 08:21:26 -0000 Received: (qmail 27252 invoked by uid 22791); 19 Feb 2011 08:21:26 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Feb 2011 08:21:20 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LGU00500V3XRQ00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sat, 19 Feb 2011 10:21:18 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.140.24]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LGU00515V7GRX00@a-mtaout23.012.net.il>; Sat, 19 Feb 2011 10:21:18 +0200 (IST) Date: Sat, 19 Feb 2011 10:37:00 -0000 From: Eli Zaretskii Subject: Re: [patch, doc RFA]: New python function lookup_global_symbol In-reply-to: <20110218235945.997602461AA@ruffy.mtv.corp.google.com> To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83zkpstoxn.fsf@gnu.org> References: <20110218235945.997602461AA@ruffy.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00508.txt.bz2 > Date: Fri, 18 Feb 2011 15:59:45 -0800 (PST) > From: dje@google.com (Doug Evans) > > --- NEWS 15 Feb 2011 21:17:52 -0000 1.426 > +++ NEWS 18 Feb 2011 23:48:45 -0000 > @@ -38,6 +38,8 @@ > > * Python scripting > > + ** New function gdb.lookup_global_symbol looks up a global symbol. > + This part is okay. > -@code{gdb.Block} object. The optional @var{domain} argument restricts > +@code{gdb.Block} object. If elided, the block for the current frame ^^^^^^ Please use "omitted" instead, it will be understood by more readers whose first language is not English. We use "omitted" in this context elsewhere in the manual. > +@defun lookup_symbol name [domain] @defun renders its arguments in @code and @var, but you want the brackets in the normal roman typeface. So this should be @defun lookup_symbol name @r{[}domain@r{]} > +This function searches for a global symbol by name. > +The search scope can be restricted to by the domain argument. > + > +@var{name} is the name of the symbol. It must be a string. > +The optional @var{domain} argument restricts the search to the domain type. > +The @var{domain} argument must be a domain constant defined in the @code{gdb} > +module and described later in this chapter. Should we tell what happens if the symbol is not found? Okay with those changes. Thanks.