From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94996-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32261 invoked by alias); 1 Oct 2012 13:18:38 -0000
Received: (qmail 32250 invoked by uid 22791); 1 Oct 2012 13:18:36 -0000
X-SWARE-Spam-Status: No, hits=-4.4 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 13:18:29 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MB700400U1UQC00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 01 Oct 2012 15:18:26 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MB70042KUAQR600@a-mtaout20.012.net.il>; Mon, 01 Oct 2012 15:18:26 +0200 (IST)
Date: Mon, 01 Oct 2012 13:18:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32
In-reply-to: <50683F26.6010004@gmail.com>
To: LRN <lrn1986@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zk46baae.fsf@gnu.org>
References: <503E575D.1000608@gmail.com> <83y5kvp0za.fsf@gnu.org> <5040DA38.2070802@gmail.com> <504F7E31.10306@redhat.com> <504F818B.6090104@gmail.com> <504F8297.5090507@redhat.com> <5066EC9B.4000409@gmail.com> <838vbtf07z.fsf@gnu.org> <50674CCF.9020800@gmail.com> <83ipawdk3n.fsf@gnu.org> <50683F26.6010004@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00004.txt.bz2

> Date: Sun, 30 Sep 2012 16:46:30 +0400
> From: LRN <lrn1986@gmail.com>
> 
> Attached the patch.

Thanks.  Final 2 comments:

  . you patch has 2 stray ^M characters, please remove them when
    committing
  . you still have at least one place with 1 space between sentences


> > The documentation patch is OK with those changes.
> You said you'd suggest a better short message for add_com().

Right, thanks for the reminder.  Here it is:

   Signal a crashed process with event ID, to allow its debugging.
 This command is needed in support of setting up GDB as JIT debugger
 on MS-Windows.  The command should be invoked from the GDB command
 line using the '-ex' command-line option.  The ID of the event that
 blocks the crashed process will be supplied by the Windows JIT
 debugging mechanism.

Well, maybe not so short ;-)

Thanks.