From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3742 invoked by alias); 4 Dec 2014 06:47:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3731 invoked by uid 89); 4 Dec 2014 06:47:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout25.012.net.il Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Dec 2014 06:47:15 +0000 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NG100700P3O8L00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Thu, 04 Dec 2014 08:42:54 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NG10012OPBI1M70@mtaout25.012.net.il>; Thu, 04 Dec 2014 08:42:54 +0200 (IST) Date: Thu, 04 Dec 2014 06:47:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled. In-reply-to: <20141204031828.GD7899@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org, yao@codesourcery.com Reply-to: Eli Zaretskii Message-id: <83zjb352te.fsf@gnu.org> References: <20141203104812.GA14666@adacore.com> <1417608509-15533-1-git-send-email-brobecker@adacore.com> <83h9xc62dw.fsf@gnu.org> <20141204031828.GD7899@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00083.txt.bz2 > Date: Thu, 4 Dec 2014 07:18:28 +0400 > From: Joel Brobecker > Cc: gdb-patches@sourceware.org, yao@codesourcery.com > > > > But gnulib ignores this fact, and so tries to determine how to > > > enable large-file support irrespective of whether we want it or not. > > > This patch fixes the issue by passing --disable-largefile to gnulib's > > > configure when large-file support in GDB is disabled. This is done > > > by first enhancing ACX_CONFIGURE_DIR to allow us to pass extra > > > arguments to be passed to the configure command, and then by modifying > > > GDB's configure to pass --disable-largefile if large-file support > > > is disabled. > > > > Shouldn't this be reported to gnulib folks and preferably fixed there? > > I do not think so, because gnulib can be used independently of procfs, > in which case you would probably want gnulib to have large-file support > by default. It's only in GDB and binutils' peculiar situation that > we need to disable by default. Gnulib could have the necessary magic to DTRT in both situations, I think. Anyway, I don't think it's wise to not even tell Gnulib folks about this. If they say it's just our problem, so be it. But they might have other proposals.