From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120310-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 36591 invoked by alias); 27 Feb 2015 14:42:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 36578 invoked by uid 89); 27 Feb 2015 14:42:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Feb 2015 14:42:52 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NKF00M00PUFWR00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 27 Feb 2015 16:42:48 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKF00MP6Q7CRG50@a-mtaout22.012.net.il>; Fri, 27 Feb 2015 16:42:48 +0200 (IST)
Date: Fri, 27 Feb 2015 14:42:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id)
In-reply-to: <54F07829.9030009@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83zj7z4dqd.fsf@gnu.org>
References: <1424699660-11727-1-git-send-email-palves@redhat.com> <1424699660-11727-6-git-send-email-palves@redhat.com> <867fv7xodw.fsf@gmail.com> <54F04A2B.5@redhat.com> <54F04E16.2070704@redhat.com> <54F05F2C.5020007@gmail.com> <54F07829.9030009@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2015-02/txt/msg00823.txt.bz2

> Date: Fri, 27 Feb 2015 13:59:05 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> >> +     Windows pipe, thus not a tty and its outputs ends up fully
> >> +     buffered.  */
> >> +#ifndef __MINGW32__
> >> +  if (!isatty (fileno (stdin)))
> >> +#endif
> > 
> > Include unistd.h for isatty?
> > 
> 
> ... with these fixed.
> 
> Do you want to comment on the rest of the series, or shall I push it?

If that's isatty from the MS runtime, it will return non-zero for
every character device, including the null device.  Is that what we
want here?