From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53150 invoked by alias); 14 Apr 2015 14:38:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52417 invoked by uid 89); 14 Apr 2015 14:38:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_20,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout25.012.net.il Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Apr 2015 14:38:51 +0000 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NMS00H00WFFJD00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Tue, 14 Apr 2015 17:33:29 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NMS00AMIWFTWQ60@mtaout25.012.net.il>; Tue, 14 Apr 2015 17:33:29 +0300 (IDT) Date: Tue, 14 Apr 2015 14:38:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Fixes to Cygwin-specific signal handling In-reply-to: <20150414131615.GI4704@adacore.com> To: Joel Brobecker Cc: jon.turney@dronecode.org.uk, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83zj6abwry.fsf@gnu.org> References: <1429009382-21040-1-git-send-email-jon.turney@dronecode.org.uk> <20150414131615.GI4704@adacore.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00525.txt.bz2 > Date: Tue, 14 Apr 2015 06:16:15 -0700 > From: Joel Brobecker > Cc: gdb-patches@sourceware.org > > Overall, the patch looks reasonable to me. But I think there are > at least 3 independent changes, and it would be nice to split those > two out, for a couple of reasons: > 1. It allows you to explain the nature of the problem, from the user's > standpoint, that the patch is fixing (ie, what user-visible > symptoms it fixes); > 2. it allows us to see how each problem is fixed, and to deal with > each issue separately. > > The three issues I view as independent: > a. ignoring "invalid handle" errors; > b. unsetting saved_context.ContextFlags > c. the renaming of have_saved_context into signal_thread_id > so you can compare the current thread id with the saved > signal_thread_id. Also, quite a few of the changes are in non-Cygwin parts, so some explanation of the issues would be appreciated, to make sure the changes are safe for the native builds as well. Thanks.