From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14065 invoked by alias); 7 May 2015 18:55:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13687 invoked by uid 89); 7 May 2015 18:55:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout23.012.net.il Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 May 2015 18:55:00 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NNZ00C00TRYKZ00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 07 May 2015 21:54:57 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNZ00CZPTVLKI10@a-mtaout23.012.net.il>; Thu, 07 May 2015 21:54:57 +0300 (IDT) Date: Thu, 07 May 2015 18:55:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v4 9/9] Explicit locations: documentation updates In-reply-to: <20150507180607.19629.20793.stgit@valrhona.uglyboxes.com> To: Keith Seitz Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83zj5gp69e.fsf@gnu.org> References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180607.19629.20793.stgit@valrhona.uglyboxes.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00168.txt.bz2 > From: Keith Seitz > Date: Thu, 07 May 2015 11:06:07 -0700 > > This patch adds documentation for explicit locations to both the > User Manual and gdb's online help system. Thanks. > (Specifying a Location): Rewrite. Add explanations for each > location type. You also added new subsections there. > (Source and Machine Code): Use "location(s)" instead of > "linespec(s)". > (C Preprocessor Macros): Likewise. > (Create and Delete Tracepoints): Likewise. > (Extensions for Ada Tasks): Likewise. Can we please avoid all those "likewises" and instead use the GNU-standard ChangeLog syntax, like this: (Source and Machine Code, C Preprocessor Macros) (Create and Delete Tracepoints, Extensions for Ada Tasks): Use "location(s)" ... > +@subsection Linespec Locations > +@anchor{Linespec Locations} I'd prefer not having subsections without @nodes. It will require adding a menu in the parent node, but will free you from the need to define an @anchor. More importantly, it will make these subsections more easily reachable in the Info reader. > +@dfn{Address locations} indicate a specific program address. They have > +the generalized form *@var{address}. ^^^^^^^^^^^^^^ This should be in @code, as in @code{*@var{address}}. > +@item address location > +An address location, *@var{address}. @xref{Address Locations}. Same here. OK with these fixed.