From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82339 invoked by alias); 2 Mar 2016 16:35:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82305 invoked by uid 89); 2 Mar 2016 16:35:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:walfred, walfred.tedeschi@intel.com, bnd, U*walfred.tedeschi X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Mar 2016 16:35:47 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab9kW-0002Dw-CH for gdb-patches@sourceware.org; Wed, 02 Mar 2016 11:35:45 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab9kR-0002DB-MA; Wed, 02 Mar 2016 11:35:39 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3454 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ab9kQ-0006Rh-SL; Wed, 02 Mar 2016 11:35:39 -0500 Date: Wed, 02 Mar 2016 16:35:00 -0000 Message-Id: <83ziug6dnw.fsf@gnu.org> From: Eli Zaretskii To: Walfred Tedeschi CC: palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org, walfred.tedeschi@intel.com In-reply-to: <1456935689-1820-3-git-send-email-walfred.tedeschi@intel.com> (message from Walfred Tedeschi on Wed, 2 Mar 2016 17:21:29 +0100) Subject: Re: [PATCH V4 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls. Reply-to: Eli Zaretskii References: <1456935689-1820-1-git-send-email-walfred.tedeschi@intel.com> <1456935689-1820-3-git-send-email-walfred.tedeschi@intel.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00037.txt.bz2 > From: Walfred Tedeschi > Cc: gdb-patches@sourceware.org, Walfred Tedeschi > Date: Wed, 2 Mar 2016 17:21:29 +0100 > > +While the using the @command{return} bounds can propagate through > +execution causing a boundary violation. This sentence needs to be rephrased. > +@kindex set mpx-bnd-init-on-return > +When set to true bound registers will be set to the INIT state when > +using the "return" command. > +@kindex show mpx-bnd-init-on-return > +Show the state of mpx-bnd-init-on-return. This last sentence should explain what is shown; just referring to the variable name doesn't do the job. > + add_setshow_boolean_cmd ("mpx-bnd-init-on-return", no_class, > + &mpx_bnd_init_on_return, _("\ > + Set the bnd registers to INIT state when returning from a call."), _("\ > + Show the state of the mpx-bnd-init-on-return."), For the 'show" part, we usually use the following wording: Show whether to set the bnd registers to INIT state when returning from a call. Thanks.