Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, simark@simark.ca
Subject: Re: [PATCHv3 2/2] gdb: Initial baremetal riscv support
Date: Sat, 03 Mar 2018 07:40:00 -0000	[thread overview]
Message-ID: <83zi3pvc78.fsf@gnu.org> (raw)
In-Reply-To: <430dd07a2ed6520ad17108eb156935ec86cec826.1520021226.git.andrew.burgess@embecosm.com>	(message from Andrew Burgess on Fri, 2 Mar 2018 20:09:49 +0000)

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Simon Marchi <simark@simark.ca>,
> 	Eli Zaretskii <eliz@gnu.org>,
> 	Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri,  2 Mar 2018 20:09:49 +0000
> 
> This commit introduces basic support for baremetal RiscV as a GDB
> target.  This target is currently only tested against the RiscV software
> simulator, which is not included as part of this commit.  The target has
> been tested against the following RiscV variants: rv32im, rv32imc,
> rv32imf, rv32imfc, rv64im, rv64imc, rv64imfd, rv64imfdc.
> 
> Across these variants we pass on average 34858 tests, and fail 272
> tests, which is ~0.8%.
> 
> The RiscV has a feature of its ABI where structures with a single
> floating point field, a single complex float field, or one float and one
> integer field are treated differently for argument passing.  The new
> test gdb.base/nested-structs.exp is added to cover this feature.  As
> passing these structures should work on all targets then I've made the
> test as a generic one, even though, for most targets, there's probably
> nothing special about any of these cases.
> 
> gdb/ChangeLog:
> 
> 	* Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
> 	(HFILES_NO_SRCDIR): Add riscv-tdep.h.
> 	(ALLDEPFILES): Add riscv-tdep.c
> 	* configure.tgt: Add riscv support.
> 	* riscv-tdep.c: New file.
> 	* riscv-tdep.h: New file.
> 	* NEWS: Mention new target.
> 	* MAINTAINERS: Add entry for riscv.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/nested-structs.exp: New file.
> 	* gdb.base/nested-structs.c: New file.
> 	* gdb.base/float.exp: Add riscv support.

The documentation part is OK.

Thanks.


  parent reply	other threads:[~2018-03-03  7:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 19:15 [PATCH] " Andrew Burgess
2018-02-13 19:49 ` Eli Zaretskii
2018-02-19 20:01 ` Simon Marchi
2018-02-27  1:09 ` [PATCHv2] " Andrew Burgess
2018-02-27  3:33   ` Simon Marchi
2018-03-02 20:09     ` [PATCHv3 0/2] Initial RiscV Support Andrew Burgess
2018-03-02 20:10     ` [PATCHv3 1/2] gdb/amd64: Ignore zero sized fields when calling functions Andrew Burgess
2018-03-03  6:29       ` Simon Marchi
2018-03-02 20:10     ` [PATCHv3 2/2] gdb: Initial baremetal riscv support Andrew Burgess
2018-03-03  6:27       ` Simon Marchi
2018-03-05 10:46         ` [PATCHv4 " Andrew Burgess
2018-03-05 22:35           ` Simon Marchi
2018-03-06 11:06           ` Yao Qi
2018-03-06 11:35           ` Yao Qi
2018-03-03  7:40       ` Eli Zaretskii [this message]
2018-02-27  3:37   ` [PATCHv2] " Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zi3pvc78.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox