From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45708 invoked by alias); 29 Apr 2019 18:52:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45700 invoked by uid 89); 29 Apr 2019 18:52:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=mechanical X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Apr 2019 18:52:45 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLBOM-0008ME-NW; Mon, 29 Apr 2019 14:52:42 -0400 Received: from [176.228.60.248] (port=3528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLBOL-0007n6-Gx; Mon, 29 Apr 2019 14:52:42 -0400 Date: Mon, 29 Apr 2019 18:52:00 -0000 Message-Id: <83zho8skya.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20190429183105.15973-3-tromey@adacore.com> (message from Tom Tromey on Mon, 29 Apr 2019 12:31:05 -0600) Subject: Re: [PATCH 2/2] Change ptype/o to print bit offset References: <20190429183105.15973-1-tromey@adacore.com> <20190429183105.15973-3-tromey@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00633.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Mon, 29 Apr 2019 12:31:05 -0600 > > With this patch, the output is now: > > (gdb) ptype/o struct outer > /* offset | size */ type = struct outer { > /* 0: 0 | 1 */ unsigned char o : 3; > /* XXX 5-bit hole */ > /* 1 | 8 */ struct inner { > /* 1 | 4 */ unsigned int x; > /* 5: 0 | 4 */ unsigned int y : 3; > /* 5: 3 | 4 */ unsigned int z : 3; > /* XXX 2-bit padding */ > /* XXX 3-byte padding */ This loses information, because now the bits part is just a trivial conversion of the field size in the declaration. The current display shows something that cannot be trivially gleaned by looking at the bitfield sizes. I'm not objecting to the change, I'm just saying we lose something here. > gdb/doc/ChangeLog > 2019-04-29 Tom Tromey > > * gdb.texinfo (Symbols): Document change to ptype/o. This seems to be a mechanical change, so OK. Do we need to call this out in NEWS? Thanks.