From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id B34233857007
 for <gdb-patches@sourceware.org>; Thu,  2 Jul 2020 13:39:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B34233857007
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:60915)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jqzRQ-00070l-6f; Thu, 02 Jul 2020 09:39:52 -0400
Received: from [176.228.60.248] (port=1161 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jqzRP-0002r8-Ig; Thu, 02 Jul 2020 09:39:52 -0400
Date: Thu, 02 Jul 2020 16:39:48 +0300
Message-Id: <83zh8ivxwb.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20200701193026.GE5340@adacore.com> (message from Joel Brobecker
 on Wed, 1 Jul 2020 12:30:26 -0700)
Subject: Re: Building today's snapshot of GDB with MinGW
References: <83a70l20dn.fsf@gnu.org>
 <83ftaczfvl.fsf@gnu.org> <20200701193026.GE5340@adacore.com>
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2020 13:39:53 -0000

> Date: Wed, 1 Jul 2020 12:30:26 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> >   AC_CHECK_TYPES(socklen_t, [], [],
> >   [#include <sys/types.h>
> >   #include <sys/socket.h>
> >   ])
> > 
> > But on Windows this fails, because sys/socket.h doesn't exist;
> > instead, socklen_t is supposed to be defined in ws2tcpip.h.  So the
> > correct headers inclusion for the test program would be
> > 
> >   #include <sys/types.h>
> >   #if HAVE_SYS_SOCKET_H
> >   # include <sys/socket.h>
> >   #elif HAVE_WS2TCPIP_H
> >   # include <ws2tcpip.h>
> > 
> > Can we please fix this minor issue?
> 
> Would you be able to submit a patch?

I can submit a change, but it would be difficult for me to try it, and
regenerate configure in general (I don't have the right version of
Autotools installed).  Would it be okay to send a change and ask
someone to do the rest?