Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Vasili Burdo <vasili.burdo@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] TUI disassembly window improvemenmt
Date: Wed, 09 Jun 2021 16:05:18 +0300	[thread overview]
Message-ID: <83zgvzcho1.fsf@gnu.org> (raw)
In-Reply-To: <CANacp63dU8qx-bO1HHe2-kXrXfNsHc0DS2sA0cRxt9Yukvi9vg@mail.gmail.com> (message from Vasili Burdo on Wed, 9 Jun 2021 15:56:38 +0300)

> From: Vasili Burdo <vasili.burdo@gmail.com>
> Date: Wed, 9 Jun 2021 15:56:38 +0300
> Cc: gdb-patches@sourceware.org
> 
> > Shouldn't this be optional behavior?  Not everyone disassembles only
> > C++ code.
> This patch does not limit disassembly view in any way.
> - The current  function name moved from disassembly line to window header
> - Offset from function start still present in disassembly line
> - Function start is marked by function name label.

But AFAIU only the current function's name is visible; if some other
function is referenced in the disassembly, it will now be invisible,
right?

IOW, you seem to assume that any function names mentioned in the
disassembly are always the name of the current function, but is that
an assumption that is always correct?

  reply	other threads:[~2021-06-09 13:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 16:16 Vasili Burdo via Gdb-patches
2021-06-08 16:21 ` Simon Marchi via Gdb-patches
2021-06-09 12:33 ` Eli Zaretskii via Gdb-patches
2021-06-09 12:56   ` Vasili Burdo via Gdb-patches
2021-06-09 13:05     ` Eli Zaretskii via Gdb-patches [this message]
2021-06-09 13:16       ` Vasili Burdo via Gdb-patches
2021-06-09 13:43         ` Eli Zaretskii via Gdb-patches
     [not found]           ` <CANacp62RQ4eTK+YYcukgxh=MzmAAdvK5AYTPe6RZubhejMePeg@mail.gmail.com>
2021-06-09 16:02             ` Fwd: " Vasili Burdo via Gdb-patches
2021-06-09 17:14         ` Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgvzcho1.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=vasili.burdo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox