From: Eli Zaretskii <eliz@gnu.org>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: fix Solaris problem with auto host charset
Date: Sat, 18 Apr 2009 06:38:00 -0000 [thread overview]
Message-ID: <83y6tyihzh.fsf@gnu.org> (raw)
In-Reply-To: <m3prfa7sd5.fsf@fleche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 17 Apr 2009 17:49:58 -0600
>
> On some versions of Solaris, nl_langinfo(CODESET) will return "646"
> for the C locale. Unfortunately, this value is not then recognized by
> iconv_open.
>
> This fixes the problem by recognizing this situation and using "ASCII"
> instead. I'm unaware of any other names needing this treatment.
Btw, why is the code assuming that nl_langinfo always returns a
meaningful result? It can potentially return an empty string.
Although this is at worst a very rare situation, perhaps we should
take it into consideration and fall back on GDB_DEFAULT_HOST_CHARSET.
Also, I don't quite get the reason why nl_langinfo is not called in
the PHONY_ICONV case. It seems we blindly assume the native charset
is Latin-1 in that case, but perhaps nl_langinfo, if it exists, will
give a better guess?
next prev parent reply other threads:[~2009-04-18 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 23:50 Tom Tromey
2009-04-18 6:38 ` Eli Zaretskii [this message]
2009-04-18 17:12 ` Tom Tromey
2009-04-21 18:53 ` Tom Tromey
2009-04-21 19:06 ` Eli Zaretskii
2009-04-21 19:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y6tyihzh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox