Re: [patch] Fix watchpoint-at-epilogue 7.0 regression (s390x)

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 27 Dec 2009 20:29:16 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> gdb/
> 2009-12-27  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* config/djgpp/fnchange.lst: Add translations for 
> 	watchpoint-cond-gone.exp, watchpoint-cond-gone.c and
> 	watchpoint-cond-gone-stripped.c.
> 
> (not tested)
> 
> I will include it on its check-in.

Thanks.

> Still I do not understand it fully - it cannot work after the rename

The test suite does not work with DJGPP, anyway, since there's no
`expect' (no async subprocesses).  So renaming does not break anything
that isn't already broken.

> and it gets extracted fine by DJGPP tar.exe:
> watch-~1.c   watch_~1.exp watchp~2.c   watchp~3.exp watchp~5.c   watchp~6.exp
> watch-~1.exp watchp~1.c   watchp~2.exp watchp~4.c   watchp~5.exp watchp~7.c
> watch_~1.c   watchp~1.exp watchp~3.c   watchp~4.exp watchp~6.c   watchp~8.c

When GDB is built for DJGPP, it needs to be extracted by djunpack.bat,
not by Tar.  That is because Tar (and gzip/bzip2) can not be
guaranteed to be available on DJGPP platforms.  djunpack.bat invokes
djtar.exe, which is part of the core DJGPP distro and includes gzip
and bzip2 decompressors built-in.  djtar.exe will complain when it
encounters file-name clashes, and will ask for a different file name.
Typing a new name for a lot of files is annoying.  The file produced
from fnchange.lst is submitted to djtar.exe to tell it how to rename
each file whose name will otherwise clash, so the user is not
bothered.  Using fnchange.lst also ensures all DJGPP users have the
same files after unpacking, instead of relying on various tools each
of which does its own trickery to cope with 8+3 namespace.

> --- a/gdb/config/djgpp/fnchange.lst
> +++ b/gdb/config/djgpp/fnchange.lst
> @@ -400,6 +400,9 @@
>  @V@/gdb/testsuite/gdb.base/watchpoint-solib.c @V@/gdb/testsuite/gdb.base/wp-solib.c
>  @V@/gdb/testsuite/gdb.base/watchpoint-hw.exp @V@/gdb/testsuite/gdb.base/wp-hw.exp
>  @V@/gdb/testsuite/gdb.base/watchpoint-solib.exp @V@/gdb/testsuite/gdb.base/wp-solib.exp
> +@V@/gdb/testsuite/gdb.base/watchpoint-cond-gone.exp @V@/gdb/testsuite/gdb.base/wpcondg.exp
> +@V@/gdb/testsuite/gdb.base/watchpoint-cond-gone.c @V@/gdb/testsuite/gdb.base/wpcondg.c
> +@V@/gdb/testsuite/gdb.base/watchpoint-cond-gone-stripped.c @V@/gdb/testsuite/gdb.base/wpcondgs.c
>  @V@/gdb/testsuite/gdb.cell/coremaker-spu.c @V@/gdb/testsuite/gdb.cell/core-spu.c
>  @V@/gdb/testsuite/gdb.cell/ea-cache-spu.c @V@/gdb/testsuite/gdb.cell/ea-spu.c
>  @V@/gdb/testsuite/gdb.cell/mem-access-spu.c @V@/gdb/testsuite/gdb.cell/mem-spu.c

This is fine.