From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26014 invoked by alias); 7 Apr 2010 03:20:11 -0000 Received: (qmail 25968 invoked by uid 22791); 7 Apr 2010 03:20:10 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 03:20:05 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L0H00700KWOC000@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 07 Apr 2010 06:19:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0H006QLL842V40@a-mtaout23.012.net.il>; Wed, 07 Apr 2010 06:19:17 +0300 (IDT) Date: Wed, 07 Apr 2010 03:20:00 -0000 From: Eli Zaretskii Subject: Re: [RFC] Fix for Go32-v2 native woes In-reply-to: <83iq84xyoa.fsf@gnu.org> To: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83y6h0vtj6.fsf@gnu.org> References: <002a01cad517$d36eab90$7a4c02b0$%muller@ics-cnrs.unistra.fr> <001801cad593$8e70daf0$ab5290d0$%muller@ics-cnrs.unistra.fr> <83iq84xyoa.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00113.txt.bz2 > Date: Tue, 06 Apr 2010 20:45:25 +0300 > From: Eli Zaretskii > Cc: gdb-patches@sourceware.org > > > From: "Pierre Muller" > > Date: Tue, 6 Apr 2010 16:15:05 +0200 > > > > I finally managed to find a fix, but it is not straightforward: > > I had to add a new xml file in features/i386 directory > > specific for go32v2 target, that does not read i386-sse.xml. > > I had to adapt the code in i386-tdep.c to support > > missing feature_vector and to set tdesc to > > tdesc_i386_go32v2 instead of tdesc_i386 when go32v2 > > osabi was detected. > > > > This allows me to use CVS GDB on DJGPP again. > > > > I checked with a testsuite run on gcc-farm that nothing changed > > for at least that other target (amd64-linux). > > > > Similar fixes might be required for other 'old' > > i386 targets that do not support SSE registers. > > > > Comments welcome as usual! > > Thanks. But I really hope that a much more elegant solution could be > found. A general layer of code such as i386-tdep.c should not include > any code that is specific to certain targets. Btw, I think this solution cannot be acceptable for one more reason: GDB should work even without libexpat linked in, and then XML files cannot be read. Can you see what happens with this problem in a GDB build without libexpat? (Sorry, I won't be able to do that myself in the near future.) TIA