From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30870 invoked by alias); 21 Sep 2012 18:36:03 -0000 Received: (qmail 30763 invoked by uid 22791); 21 Sep 2012 18:36:03 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Sep 2012 18:35:43 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MAP00B00QAE6G00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 21 Sep 2012 21:35:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAP00ASZQBGRD90@a-mtaout20.012.net.il>; Fri, 21 Sep 2012 21:35:41 +0300 (IDT) Date: Fri, 21 Sep 2012 18:36:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists In-reply-to: <20120921182637.GA8747@host2.jankratochvil.net> To: Jan Kratochvil Cc: khooyp@cs.umd.edu, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83y5k3w7es.fsf@gnu.org> References: <21ACC598-F6B4-4117-BA7B-B316414DE9E3@cs.umd.edu> <20120919130040.GA20442@host2.jankratochvil.net> <20120921182637.GA8747@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00448.txt.bz2 > Date: Fri, 21 Sep 2012 20:26:37 +0200 > From: Jan Kratochvil > Cc: GDB Patches > > if (stat (path, &s) != 0 || (isdir && !S_ISDIR (s.st_mode)) > || (!isdir && S_ISDIR (s.st_mode))) a.k.a. if (stat (path, &s) != 0 || isdir != S_ISDIR (s.st_mode))