From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99938-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22420 invoked by alias); 27 Mar 2013 06:48:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22401 invoked by uid 89); 27 Mar 2013 06:48:34 -0000
X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 06:48:31 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MKB00I003OXIP00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Mar 2013 08:48:28 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKB00IH848RJH00@a-mtaout23.012.net.il>; Wed, 27 Mar 2013 08:48:27 +0200 (IST)
Date: Wed, 27 Mar 2013 10:02:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA]  Fix cygwin32 failure introduced by  [patch] windows-nat.c: Fix offset problem in signal string handling
In-reply-to: <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org, vinschen@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83y5d9xrqt.fsf@gnu.org>
References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr>
X-SW-Source: 2013-03/txt/msg01003.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: "'Corinna Vinschen'" <vinschen@redhat.com>
> Date: Tue, 26 Mar 2013 22:47:43 +0100
> 
> make[1]: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb'
> gcc -gstabs+ -O0    -I. -I../../src/gdb -I../../src/gdb/common
> -I../../src/gdb/config  -DLOCALEDIR="\"/usr/local/share/l
> ocale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
> -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/..
>  -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include
> -I../libdecnumber -I../../src/gdb/../libdecnumber   -I../../
> src/gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1
> -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclara
> tion-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign
> -Wno-unused -Wunused-value -Wunused-function
> -Wno-switch -Wno-char-subscripts -Wmissing-prototypes
> -Wdeclaration-after-statement -Wempty-body -Werror -c -o windows-n
> at.o -MT windows-nat.o -MMD -MP  -MF .deps/windows-nat.Tpo
> ../../src/gdb/windows-nat.c
> cc1: warnings being treated as errors
> ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string':
> ../../src/gdb/windows-nat.c:993:18: error: cast to pointer from integer of
> different size
> Makefile:972: recipe for target `windows-nat.o' failed
> make: *** [windows-nat.o] Error 1
> make: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb'
> 
> This failure can be fixed by this simple patch, which should
> not affect the unreleased 64-bit Cygwin, a confirmation
> by Corinna would be nice on this part...
> 
> 
> ChangeLog entry:
> 
> 2013-03-26  Pierre Muller  <muller@sourceware.org>
> 
>         * windows-nat.c (handle_output_debug_string): Avoid typecast
>         from integer of different size warning.
> 
> 
> Index: windows-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/windows-nat.c,v
> retrieving revision 1.245
> diff -u -p -r1.245 windows-nat.c
> --- windows-nat.c       23 Mar 2013 10:48:23 -0000      1.245
> +++ windows-nat.c       26 Mar 2013 21:39:57 -0000
> @@ -990,7 +990,7 @@ handle_output_debug_string (struct targe
>           retval = strtoul (p, &p, 0);
>           if (!retval)
>             retval = main_thread_id;
> -         else if ((x = (LPCVOID) strtoull (p, NULL, 0))
> +         else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0))
>                    && ReadProcessMemory (current_process_handle, x,
>                                          &saved_context,
>                                          __COPY_CONTEXT_SIZE, &n)

Is the cast to LPCVOID really needed?  What if you drop it (and not
add the cast to uintptr_t)?