From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102418-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14397 invoked by alias); 13 Jun 2013 02:46:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14365 invoked by uid 89); 13 Jun 2013 02:46:53 -0000
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 13 Jun 2013 02:46:51 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MOB00B0091TAL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 13 Jun 2013 05:46:49 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MOB00B7Y9214360@a-mtaout20.012.net.il>; Thu, 13 Jun 2013 05:46:49 +0300 (IDT)
Date: Thu, 13 Jun 2013 03:40:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 4/6] Add id of TSV into traceframe_info.
In-reply-to: <1371086914-8398-5-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83y5aewwv2.fsf@gnu.org>
References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1371086914-8398-1-git-send-email-yao@codesourcery.com> <1371086914-8398-5-git-send-email-yao@codesourcery.com>
X-SW-Source: 2013-06/txt/msg00302.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 13 Jun 2013 09:28:32 +0800
> 
> Hi,
> This patch extends the qXfer:traceframe-info object to report the set
> of collected trace state variables in the current traceframe.
> 
> Since VEC(int) is used in tracepoint.h, to avoid duplicated definition
> error, this patch also moves DEF_VEC_I(int) to gdb_vecs.h, and include
> it in other files instead of defining it by their own.
> 
> When GDB reads from trace file (tfile or ctf), the traceframe_ifo
> object should be updated for trace state variables as well.
> 
> gdb:
> 
> 2013-06-13  Pedro Alves  <pedro@codesourcery.com>
> 	    Yao Qi  <yao@codesourcery.com>
> 
> 	* ctf.c (ctf_traceframe_info): Push trace state variables
> 	present in the trace data into the traceframe info object.
> 	* breakpoint.c (DEF_VEC_I): Remove.
> 	* common/filestuff.c (DEF_VEC_I): Likewise.
> 	* dwarf2loc.c (DEF_VEC_I): Likewise.
> 	* mi/mi-main.c (DEF_VEC_I): Likewise.
> 	* common/gdb_vecs.h (DEF_VEC_I): Define vector for int.
> 	* features/traceframe-info.dtd: Add tvar element and its
> 	attributes.
> 	* tracepoint.c (free_traceframe_info): Free vector 'tvars'.
> 	(build_traceframe_info): Push trace state variables present in the
> 	trace data into the traceframe info object.
> 	(traceframe_info_start_tvar): New function.
> 	(tvar_attributes): New.
> 	(traceframe_info_children): Add "tvar" element.
> 	* tracepoint.h (struct traceframe_info) <tvars>: New field.
> 
> 	* NEWS: Mention the change in GDB and GDBserver.
> 
> gdb/doc:
> 
> 2013-06-13  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* gdb.texinfo (Traceframe Info Format): Document tvar element and
> 	its attributes.
> 
> gdb/gdbserver:
> 
> 2013-06-13  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* tracepoint.c (build_traceframe_info_xml): Output trace state
> 	variables present in the trace buffer.

The documentation parts are OK.  Thanks.