From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13848 invoked by alias); 5 Feb 2015 16:27:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13835 invoked by uid 89); 5 Feb 2015 16:27:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Feb 2015 16:27:40 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NJB00L0040OZ000@mtaout28.012.net.il> for gdb-patches@sourceware.org; Thu, 05 Feb 2015 18:25:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJB00MQX4B3NO00@mtaout28.012.net.il>; Thu, 05 Feb 2015 18:25:51 +0200 (IST) Date: Thu, 05 Feb 2015 16:27:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v4 4/9] record btrace: add configuration struct In-reply-to: <1423150072-21229-5-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83y4oce32j.fsf@gnu.org> References: <1423150072-21229-1-git-send-email-markus.t.metzger@intel.com> <1423150072-21229-5-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00137.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org > Date: Thu, 5 Feb 2015 16:27:47 +0100 > > 2015-02-05 Markus Metzger > > * Makefile.in (XMLFILES): Add btrace-conf.dtd. > * x86-linux-nat.c (x86_linux_enable_btrace): Update parameters. > (x86_linux_btrace_conf): New. > (x86_linux_create_target): Initialize to_btrace_conf. > * nat/linux-btrace.c (linux_enable_btrace): Update parameters. > Check format. Split into this and ... > (linux_enable_bts): ... this. > (linux_btrace_conf): New. > (perf_event_skip_record): Renamed into ... > (perf_event_skip_bts_record): ... this. Updated users. > (linux_disable_btrace): Split into this and ... > (linux_disable_bts): ... this. > (linux_read_btrace): Check format. > * nat/linux-btrace.h (linux_enable_btrace): Update parameters. > (linux_btrace_conf): New. > (btrace_target_info): Moved. > (btrace_target_info): New. > (btrace_target_info): Split into this and ... > (btrace_tinfo_bts): ... this. Updated users. > * btrace.c (btrace_enable): Update parameters. > (btrace_conf, parse_xml_btrace_conf_bts, parse_xml_btrace_conf) > (btrace_conf_children, btrace_conf_attributes) > (btrace_conf_elements): New. > * btrace.h (btrace_enable): Update parameters. > (btrace_conf, parse_xml_btrace_conf): New. > * common/btrace-common.h (btrace_config): New. > * feature/btrace-conf.dtd: New. > * record-btrace.c (record_btrace_conf): New. > (record_btrace_cmdlist): New. > (record_btrace_enable_warn, record_btrace_open): Pass > &record_btrace_conf. > (record_btrace_info): Print recording format. > (cmd_record_btrace_bts_start): New. > (cmd_record_btrace_start): Call cmd_record_btrace_bts_start. > (_initialize_record_btrace): Add "record btrace bts" subcommand. > Add "record bts" alias command. > * remote.c (remote_state): New. > (remote_btrace_reset, PACKET_qXfer_btrace_conf): New. > (remote_protocol_features): Add qXfer:btrace-conf:read. > (remote_open_1): Call remote_btrace_reset. > (remote_xfer_partial): Handle TARGET_OBJECT_BTRACE_CONF. > (btrace_target_info): New. > (btrace_sync_conf, btrace_read_config): New. > (remote_enable_btrace): Update parameters. Call btrace_sync_conf and > btrace_read_conf. > (remote_btrace_conf): New. > (init_remote_ops): Initialize to_btrace_conf. > (_initialize_remote): Add qXfer:btrace-conf packet. > * target.c (target_enable_btrace): Update parameters. > (target_btrace_conf): New. > * target.h (target_enable_btrace): Update parameters. > (target_btrace_conf): New. > (target_object): New. > (target_ops): Update parameters and comment. > (target_ops): New. > * target-delegates: Regenerate. > * target-debug.h (target_debug_print_const_struct_btrace_config_p) > (target_debug_print_const_struct_btrace_target_info_p): New. > NEWS: Announce new command and new packet. > > doc/ > * gdb.texinfo (Process Record and Replay): Describe the "record > btrace bts" command. > (General Query Packets): Describe qXfer:btrace-conf:read packet. > (Branch Trace Configuration Format): New. > > gdbserver/ > * linux-low.c (linux_low_enable_btrace): Update parameters. > (linux_low_btrace_conf): New. > (linux_target_ops): Initialize. > * server.c (current_btrace_conf): New. > (handle_btrace_enable): Rename to ... > (handle_btrace_enable_bts): ... this. Pass ¤t_btrace_conf > to target_enable_btrace. Update comment. Update users. > (handle_qxfer_btrace_conf): New. > (qxfer_packets): Add btrace-conf entry. > (handle_query): Report qXfer:btrace-conf:read as supported packet. > * target.h (target_ops): Update parameters and comment. > (target_ops): New. > (target_enable_btrace): Update parameters. > (target_read_btrace_conf): New. > > testsuite/ > * gdb.btrace/delta.exp: Update "info record" output. > * gdb.btrace/enable.exp: Update "info record" output. > * gdb.btrace/finish.exp: Update "info record" output. > * gdb.btrace/instruction_history.exp: Update "info record" output. > * gdb.btrace/next.exp: Update "info record" output. > * gdb.btrace/nexti.exp: Update "info record" output. > * gdb.btrace/step.exp: Update "info record" output. > * gdb.btrace/stepi.exp: Update "info record" output. > * gdb.btrace/nohist.exp: Update "info record" output. OK for the documentation parts. Thanks.