From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120639-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 111069 invoked by alias); 11 Mar 2015 16:15:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111045 invoked by uid 89); 11 Mar 2015 16:15:14 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Mar 2015 16:15:13 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NL200B002CWUQ00@a-mtaout22.012.net.il>; Wed, 11 Mar 2015 18:15:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NL200BCV2H9PJ60@a-mtaout22.012.net.il>; Wed, 11 Mar 2015 18:15:10 +0200 (IST)
Date: Wed, 11 Mar 2015 16:15:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb
In-reply-to: <54FF77D6.7010400@eagerm.com>
To: Michael Eager <eager@eagerm.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83y4n34ik9.fsf@gnu.org>
References: <54FF77D6.7010400@eagerm.com>
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00303.txt.bz2

> Date: Tue, 10 Mar 2015 16:01:42 -0700
> From: Michael Eager <eager@eagerm.com>
> 
> GDB/DOC:
>    * gdb.texinfo: Mention gzipped exec and core files.

This should mention the name of the node where you make changes; see
the other ChangeLog entries in gdb/doc/.

Do we need a NEWS entry for this?

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -17391,6 +17391,11 @@ via @code{gdbserver} (@pxref{Server, file, Using the @code{gdbserver}
>  Program}).  In these situations the @value{GDBN} commands to specify
>  new files are useful.
>  
> +Executable and core files may be compressed using @code{gzip}.  These

'gzip' is a command, so please use @command, not @code.

> +files will be uncompressed into temporary files either in /tmp

'/tmp' is a file name, so please use @file for its markup.

>                                                                 or in 
> +@code{$TMPDIR} if this is set in the environment.

I'd prefer to say

  in the system-wide temporary directory

and mention neither /tmp nor $TMPDIR, as both are platform-dependent.

Otherwise, the documentation parts are OK.

I agree with Mike that it's better to use library functions for
creating temporary files, since that hides platform dependencies.

Thanks.