From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27703 invoked by alias); 25 Nov 2015 17:53:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27691 invoked by uid 89); 25 Nov 2015 17:53:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_FAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Nov 2015 17:53:34 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NYD00M00THJKX00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 25 Nov 2015 19:53:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYD00M69TP7K620@a-mtaout20.012.net.il>; Wed, 25 Nov 2015 19:53:32 +0200 (IST) Date: Wed, 25 Nov 2015 17:53:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 08/18] gdbserver resume_stop handling bug In-reply-to: <5655CFDA.2070308@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83y4dmvuco.fsf@gnu.org> References: <1444836486-25679-1-git-send-email-palves@redhat.com> <1444836486-25679-9-git-send-email-palves@redhat.com> <83a8rlxv6v.fsf@gnu.org> <5655CFDA.2070308@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00528.txt.bz2 > Date: Wed, 25 Nov 2015 15:12:26 +0000 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > >> infrun: Thread 1639.22253 executing, already stopping > > ^^^^^^^^^^^^^^^^ > > This is bad English. Suggest to change to "already stopped". > > In this case, "already stopped" would be misleading, as the thread > isn't really fully stopped yet. This is logging the process of > stopping all threads, conveying "already in progress of being stopped". > IOW, "Thread foo is executing, and we're already stopping it". The problem is that this sentence makes "executing" and "stopping" seem to refer to the same entity, which is not what you want. As you say above: the _thread_ is executing, and _we_ are stopping it. So if my suggestion seems too inaccurate to you (personally, I don't think that nit will matter, but that's me), then we should rephrase this more radically. How about infrun: Thread 1639.22253 executing, about to stop or infrun: Thread 1639.22253 in process of being stopped or even infrun: Thread 1639.22253 was requested to stop, still didn't Or something along these lines. Thanks.